apply review comments

Author: ndgrigorian

dpctl/_sycl_device.pyx

@@ -2879,9 +2879,9 @@ cdef class SyclDevice(_SyclDevice):
 
         Parameters:
             language
-                Input language. Possible values are "spirv" for SPIR-V binary
-                files, "opencl" for OpenCL C device code and "sycl" for SYCL
-                device code.
+                Input language. Possible values are "spirv" or "spv" for
+                SPIR-V binary files, "opencl" or "ocl" for OpenCL C device code
+                and "sycl" for SYCL device code.
 
         Returns:
             bool:

dpctl/_sycl_queue.pxd

@@ -68,16 +68,16 @@ cdef public api class SyclQueue (_SyclQueue) [
     cdef int _populate_range(self, size_t Range[3], list gS, size_t nGS)
 
     @staticmethod
-    cdef  SyclQueue _create(DPCTLSyclQueueRef qref)
+    cdef SyclQueue _create(DPCTLSyclQueueRef qref)
 
     @staticmethod
-    cdef  SyclQueue _create_from_context_and_device(
+    cdef SyclQueue _create_from_context_and_device(
         SyclContext ctx, SyclDevice dev, int props=*
     )
     cdef cpp_bool equals(self, SyclQueue q)
     cpdef SyclContext get_sycl_context(self)
     cpdef SyclDevice get_sycl_device(self)
-    cdef  DPCTLSyclQueueRef get_queue_ref(self)
+    cdef DPCTLSyclQueueRef get_queue_ref(self)
     cpdef SyclEvent _submit_keep_args_alive(
         self,
         object args,

dpctl/program/_program.pxd

@@ -55,9 +55,9 @@ cdef api class SyclKernelBundle [
     cdef bint _is_sycl_source
 
     @staticmethod
-    cdef  SyclKernelBundle _create (DPCTLSyclKernelBundleRef kbref,
-                                    bint _is_sycl_source)
-    cdef  DPCTLSyclKernelBundleRef get_kernel_bundle_ref (self)
+    cdef SyclKernelBundle _create (DPCTLSyclKernelBundleRef kbref,
+                                   bint _is_sycl_source)
+    cdef DPCTLSyclKernelBundleRef get_kernel_bundle_ref (self)
     cpdef SyclKernel get_sycl_kernel(self, str kernel_name)
 
 

dpctl/program/_program.pyx

@@ -246,7 +246,15 @@ cdef class SyclKernelBundle:
 
     SyclKernelBundle exposes the C API from
     ``dpctl_sycl_kernel_bundle_interface.h``. A SyclKernelBundle can be
-    created from either a source string or a SPIR-V binary file.
+    created from an OpenCL C source string
+    (:func:`.create_kernel_bundle_from_source`), a SPIR-V binary file
+    (:func:`.create_kernel_bundle_from_spirv`), or a SYCL source string
+    (:func:`.create_kernel_bundle_from_sycl_source`).
+
+    Creation from SYCL source uses the DPC++ ``kernel_compiler`` extension,
+    which requires both a compiler and a device that support it. Use
+    :func:`.is_sycl_source_compilation_available` to check for compiler
+    support.
     """
 
     @staticmethod

dpctl/tests/test_sycl_program.py

@@ -551,18 +551,17 @@ def test_create_kernel_bundle_from_invalid_src_sycl(queue_selector):
         out[globalID] = in1[globalID] + in2[globalID];
     }
     """
-    try:
-        _ = dpctl.program.create_kernel_bundle_from_sycl_source(
+    with pytest.raises(
+        dpctl_prog.SyclKernelBundleCompilationError,
+        match="error: expected ';' at end of declaration",
+    ):
+        dpctl.program.create_kernel_bundle_from_sycl_source(
             q,
             sycl_source,
             headers=[],
             registered_names=[],
             copts=[],
         )
-        assert False
-    except dpctl_prog.SyclKernelBundleCompilationError as prog_error:
-        print(str(prog_error))
-        assert "error: expected ';' at end of declaration" in str(prog_error)
 
 
 def test_sycl_source_compilation_is_available_returns_bool():