From 1bb0a6eeda8b8201304f673c0743f5befb411802 Mon Sep 17 00:00:00 2001 From: Louis Parkin Date: Tue, 4 Aug 2026 14:34:03 +0200 Subject: [PATCH] STAC-25520 Remove dead S3 binary publishing script packaging/publish_staging_package.sh uploaded the process-agent binary and ebpf-object-files.tar.gz to s3://stackstate-process-agent-2-test/binaries/ with --acl public-read. It was called by the `publish_binaries` job in .gitlab-ci-x64.yml and .gitlab-ci-arm.yml, both retired with the GitLab pipeline. Nothing has called it since. It is not worth reimplementing on GitHub, because nothing consumes what it produced: - The only consumer ever found is stackstate-agent's omnibus software def omnibus/config/software/stackstate-process-agent.rb, which curls the binary back out of that bucket. It is only declared as a dependency on origin/master, whose last commit is 2024-08-27. The active branches -- stackstate-7.71.2 (production) and stackstate-7.78.2 (default) -- do not declare it, so omnibus never builds it there. The standalone process-agent ships as a Kubernetes image now, which is why the image is named stackstate-k8s-process-agent. - beest does not use it. It resolves a branch to an 8-char short SHA and pulls the matching image tag, so it consumes the registry, not S3. - Nothing else in this repo references the script. - No AWS credentials are provisioned to this repo in pulumi-infra, so restoring the capability would mean granting new ones for something with no consumer, and re-establishing a public-read bucket of build artifacts. Empirically it has also been off since the GitLab pipeline was retired with no reported breakage. Reversible via git history if a consumer turns up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- packaging/publish_staging_package.sh | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100755 packaging/publish_staging_package.sh diff --git a/packaging/publish_staging_package.sh b/packaging/publish_staging_package.sh deleted file mode 100755 index a587dcdf..00000000 --- a/packaging/publish_staging_package.sh +++ /dev/null @@ -1,24 +0,0 @@ -#!/bin/sh - -if [ -z ${STS_AWS_BUCKET+x} ]; then - echo "Missing STS_AWS_BUCKET in environment" - exit 1 -fi - -if [ -z ${PROCESS_AGENT_VERSION+x} ]; then - echo "$PROCESS_AGENT_VERSION was not set" - exit 1 -fi -echo $PROCESS_AGENT_VERSION -FILENAME="process-agent-$SHORT_ARCH-$PROCESS_AGENT_VERSION" -EBPF_FILENAME="process-agent-$SHORT_ARCH-$PROCESS_AGENT_VERSION-ebpf.tar.gz" -WORKSPACE=${WORKSPACE:-$PWD/..} -agent_path="$WORKSPACE" - -echo "Uploading agent binary" - -aws s3 cp $agent_path/process-agent s3://${STS_AWS_BUCKET:-stackstate-process-agent-test}/binaries/${PACKAGING_BRANCH:-dirty}/$FILENAME --acl public-read - -tar -cvz -f $agent_path/ebpf-object-files.tar.gz -C $agent_path ebpf-object-files - -aws s3 cp $agent_path/ebpf-object-files.tar.gz s3://${STS_AWS_BUCKET:-stackstate-process-agent-test}/binaries/${PACKAGING_BRANCH:-dirty}/$EBPF_FILENAME --acl public-read \ No newline at end of file