Environment
- DependencyControl v0.9.0 (also present in v0.8.2)
- Aegisub (arch1t3cht's fork) on Windows
- Toolbox macro "DependencyControl/Install Script"
Problem 1: no progress feedback while crawling feeds
The install macro in macros/l0.DependencyControl.Toolbox.moon never calls aegisub.progress.task, so during the feed crawl (buildFeedInventory! / crawlWithPrompt, ~9 seconds with the default 21 feeds) the BackgroundScriptRunner progress dialog stays completely blank. There is no indication that anything is happening, which reads as a hang.
crawlWithPrompt itself doesn't report progress either, and the file contains no aegisub.progress.* call at all:
macros, modules = {}, {}
entries = crawlWithPrompt buildFeedInventory!
logger\log msgs.install.scanning, #entries
logger\log only writes to the DependencyControl log file, so it doesn't help here.
Problem 2: silent empty list when everything is already registered
addAvailableToInstall filters against config.c[section][namespace], and since automation scripts are registered automatically at startup, the install list is usually empty — the macro then pops the script list dialog with only a "Cancel" button and no explanation.
Suggested fix
- Call
aegisub.progress.task "Scanning available feeds..." before the crawl and aegisub.progress.task "Loading feed data..." before loading the feed data, so the progress dialog shows what's going on.
- When both
macros and modules end up empty, tell the user everything is already installed (e.g. a small label dialog or at least a log message) instead of silently showing an empty "Cancel"-only dialog.
I have a patch ready and will open a PR referencing this issue.
Environment
Problem 1: no progress feedback while crawling feeds
The
installmacro inmacros/l0.DependencyControl.Toolbox.moonnever callsaegisub.progress.task, so during the feed crawl (buildFeedInventory!/crawlWithPrompt, ~9 seconds with the default 21 feeds) the BackgroundScriptRunner progress dialog stays completely blank. There is no indication that anything is happening, which reads as a hang.crawlWithPromptitself doesn't report progress either, and the file contains noaegisub.progress.*call at all:logger\logonly writes to the DependencyControl log file, so it doesn't help here.Problem 2: silent empty list when everything is already registered
addAvailableToInstallfilters againstconfig.c[section][namespace], and since automation scripts are registered automatically at startup, the install list is usually empty — the macro then pops the script list dialog with only a "Cancel" button and no explanation.Suggested fix
aegisub.progress.task "Scanning available feeds..."before the crawl andaegisub.progress.task "Loading feed data..."before loading the feed data, so the progress dialog shows what's going on.macrosandmodulesend up empty, tell the user everything is already installed (e.g. a small label dialog or at least a log message) instead of silently showing an empty "Cancel"-only dialog.I have a patch ready and will open a PR referencing this issue.