Harden macOS module compiler wrapper

Author: mearvk

scripts/compile-all-modules-macos.sh

@@ -1,22 +1,30 @@
-#!/bin/bash
-# ═══════════════════════════════════════════════════════════════════════════════
-# NitroWebExpress™ — Compile All Modules (macOS)
-# Wrapper around compile-all-modules.sh that sets JAVA_HOME for macOS.
-# Usage: bash scripts/compile-all-modules-macos.sh
-# ═══════════════════════════════════════════════════════════════════════════════
+#!/usr/bin/env bash
+# NitroWebExpress — Compile All Modules (macOS)
+# Location-independent wrapper around compile-all-modules.sh.
+set -euo pipefail
 
-ROOT="$(cd "$(dirname "$0")/.." && pwd)"
+SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
+ROOT="$(cd -- "$SCRIPT_DIR/.." && pwd -P)"
 
-# Set JAVA_HOME for macOS
-export JAVA_HOME="${JAVA_HOME:-$(/usr/libexec/java_home -v 21 2>/dev/null || echo /opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home)}"
+if [[ -z "${JAVA_HOME:-}" ]]; then
+    if command -v /usr/libexec/java_home >/dev/null 2>&1; then
+        JAVA_HOME="$(/usr/libexec/java_home -v 21 2>/dev/null || true)"
+    fi
+fi
+if [[ -z "${JAVA_HOME:-}" || ! -d "$JAVA_HOME" ]]; then
+    for candidate in \
+        /opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home \
+        /usr/local/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home; do
+        if [[ -d "$candidate" ]]; then JAVA_HOME="$candidate"; break; fi
+    done
+fi
 
-if [ ! -d "$JAVA_HOME" ]; then
-    echo "[FAIL] Java 21 not found. Install: brew install openjdk@21"
+if [[ -z "${JAVA_HOME:-}" || ! -x "$JAVA_HOME/bin/javac" ]]; then
+    echo "[FAIL] Java 21 not found. Install OpenJDK 21 (for example: brew install openjdk@21)." >&2
     exit 1
 fi
 
-echo "[*] JAVA_HOME=$JAVA_HOME"
+export JAVA_HOME
 export PATH="$JAVA_HOME/bin:$PATH"
-
-# The main compile script is Linux/macOS compatible (: classpath separator)
+echo "[*] JAVA_HOME=$JAVA_HOME"
 exec bash "$ROOT/scripts/compile-all-modules.sh" "$@"