diff --git a/doc/object.md b/doc/object.md index 487dced9b..e01eea465 100644 --- a/doc/object.md +++ b/doc/object.md @@ -75,8 +75,8 @@ Creates a new `Napi::Object` value. Napi::Object Napi::Object::New( napi_env env, napi_value prototypeOrNull, - std::vector& propertyNames, - std::vector& propertyValues); + const std::vector& propertyNames, + const std::vector& propertyValues); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Value` object. diff --git a/napi-inl.h b/napi-inl.h index 8187fa73d..3158d5e4a 100644 --- a/napi-inl.h +++ b/napi-inl.h @@ -1644,8 +1644,8 @@ inline Object Object::New(napi_env env) { #ifdef NODE_API_EXPERIMENTAL_HAS_CREATE_OBJECT_WITH_PROPERTIES inline Object Object::New(napi_env env, napi_value prototypeOrNull, - std::vector& propertyNames, - std::vector& propertyValues) { + const std::vector& propertyNames, + const std::vector& propertyValues) { if (propertyNames.size() != propertyValues.size()) { NAPI_THROW( Napi::Error::New(env, "Mismatch in size of property names and values"), @@ -1653,13 +1653,13 @@ inline Object Object::New(napi_env env, } napi_value value; - napi_status status = - node_api_create_object_with_properties(env, - prototypeOrNull, - propertyNames.data(), - propertyValues.data(), - propertyNames.size(), - &value); + napi_status status = node_api_create_object_with_properties( + env, + prototypeOrNull, + const_cast(propertyNames.data()), + const_cast(propertyValues.data()), + propertyNames.size(), + &value); NAPI_THROW_IF_FAILED(env, status, Object()); return Object(env, value); diff --git a/napi.h b/napi.h index 8a5a23ed9..6b4692c7d 100644 --- a/napi.h +++ b/napi.h @@ -955,8 +955,8 @@ class Object : public TypeTaggable { static Object New( napi_env env, ///< Node-API environment napi_value prototypeOrNull, ///< Prototype (Object) or null / empty Value - std::vector& propertyNames, ///< Property names - std::vector& propertyValues ///< Property values + const std::vector& propertyNames, ///< Property names + const std::vector& propertyValues ///< Property values ); #endif