From 22423cc8b3efd7035ab52535c01d8f7c6585d208 Mon Sep 17 00:00:00 2001 From: Longfang Zhao Date: Fri, 28 Aug 2026 17:40:24 -0700 Subject: [PATCH] Mark ~CPUCachingAllocator override Summary: MemoryAllocator declares a virtual destructor, so ~CPUCachingAllocator already overrides it implicitly. Without the keyword, -Winconsistent-missing-destructor-override fires, and it is -Werror on the iphoneos configs, which breaks every Apple build that reaches this header. Differential Revision: D117944096 --- extension/memory_allocator/cpu_caching_malloc_allocator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension/memory_allocator/cpu_caching_malloc_allocator.h b/extension/memory_allocator/cpu_caching_malloc_allocator.h index 9f352c9aaa1..73895c30fa2 100644 --- a/extension/memory_allocator/cpu_caching_malloc_allocator.h +++ b/extension/memory_allocator/cpu_caching_malloc_allocator.h @@ -84,7 +84,7 @@ class CPUCachingAllocator : public executorch::runtime::MemoryAllocator { size_t size, size_t alignment = kCachingAllocatorDefaultAlignment) override; void reset() override; - ~CPUCachingAllocator(); + ~CPUCachingAllocator() override; }; } // namespace executorch::extension