From 983adcbcdf855395796c748e56f0be7f7cd54cb2 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Fri, 28 Aug 2026 01:06:48 -0700 Subject: [PATCH] Cover `react/renderer/element` with Stable API guards Summary: Classifies `react/renderer/element:element` as a private target under the C++ stable API three-tier visibility model. Adds `#include ` to the module's four exported headers (`Element.h`, `ElementFragment.h`, `ComponentBuilder.h`, `testUtils.h`), and wires the guard dependency into BUCK and CMake. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Differential Revision: D117837637 --- .../ReactCommon/react/renderer/element/CMakeLists.txt | 1 + .../ReactCommon/react/renderer/element/ComponentBuilder.h | 2 ++ .../react-native/ReactCommon/react/renderer/element/Element.h | 2 ++ .../ReactCommon/react/renderer/element/ElementFragment.h | 2 ++ .../react-native/ReactCommon/react/renderer/element/testUtils.h | 2 ++ 5 files changed, 9 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/element/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/element/CMakeLists.txt index ead1c1a234ac..4ba0d268fc6e 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/element/CMakeLists.txt @@ -16,6 +16,7 @@ target_include_directories(react_renderer_element PUBLIC ${REACT_COMMON_DIR}) target_link_libraries(react_renderer_element folly_runtime glog + react_cxxstableapi react_renderer_core react_renderer_componentregistry ) diff --git a/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h b/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h index 508cd5c0de05..f793f305f6fa 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h +++ b/packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/element/Element.h b/packages/react-native/ReactCommon/react/renderer/element/Element.h index 251cb49c49d5..0c5e1a28fb17 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/Element.h +++ b/packages/react-native/ReactCommon/react/renderer/element/Element.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/element/ElementFragment.h b/packages/react-native/ReactCommon/react/renderer/element/ElementFragment.h index 316c4256dc23..f7933da2cc36 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/ElementFragment.h +++ b/packages/react-native/ReactCommon/react/renderer/element/ElementFragment.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/element/testUtils.h b/packages/react-native/ReactCommon/react/renderer/element/testUtils.h index 48277f9f2fc3..fde784533858 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/testUtils.h +++ b/packages/react-native/ReactCommon/react/renderer/element/testUtils.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include