From 4c41561515f3b11fe75cada466dfeca8123b2e91 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Fri, 28 Aug 2026 06:38:51 -0700 Subject: [PATCH] Cover `react/renderer/animations` with guards Summary: Classifies `react/renderer/animations:animations` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include ` to the module's six exported headers (`LayoutAnimationCallbackWrapper.h`, `LayoutAnimationDriver.h`, `LayoutAnimationKeyFrameManager.h`, `conversions.h`, `primitives.h`, `utils.h`), and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D117863703 --- .../ReactCommon/react/renderer/animations/CMakeLists.txt | 1 + .../react/renderer/animations/LayoutAnimationCallbackWrapper.h | 2 ++ .../react/renderer/animations/LayoutAnimationDriver.h | 2 ++ .../react/renderer/animations/LayoutAnimationKeyFrameManager.h | 2 ++ .../ReactCommon/react/renderer/animations/conversions.h | 2 ++ .../ReactCommon/react/renderer/animations/primitives.h | 2 ++ .../react-native/ReactCommon/react/renderer/animations/utils.h | 2 ++ 7 files changed, 13 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt index a29c773ca891..377d8de9e265 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/animations/CMakeLists.txt @@ -18,6 +18,7 @@ target_link_libraries(react_renderer_animations glog glog_init jsi + react_cxxstableapi react_debug react_renderer_componentregistry react_renderer_core diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h index 53ba7915c490..69eab497b71a 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationCallbackWrapper.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h index 7e22dfe8d156..9fb2f666201c 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h index 977be17b0a45..9edf8e713019 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/conversions.h b/packages/react-native/ReactCommon/react/renderer/animations/conversions.h index 1eb38ae28225..f72700004c53 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/conversions.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h index b43c53474fbc..289bc634e4ed 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/primitives.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/primitives.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animations/utils.h b/packages/react-native/ReactCommon/react/renderer/animations/utils.h index 1f471d0d0a95..9f1bb4d8349a 100644 --- a/packages/react-native/ReactCommon/react/renderer/animations/utils.h +++ b/packages/react-native/ReactCommon/react/renderer/animations/utils.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include