Skip to content

Update from task 6fd8db8f-ad29-40d7-9fa3-0c09adcf72dc - #2

Closed
2002yy wants to merge 2 commits into
mainfrom
code-review-guidelines-f72dc
Closed

Update from task 6fd8db8f-ad29-40d7-9fa3-0c09adcf72dc#2
2002yy wants to merge 2 commits into
mainfrom
code-review-guidelines-f72dc

Conversation

@2002yy

@2002yy 2002yy commented May 19, 2026

Copy link
Copy Markdown
Owner

This automated PR is obsolete and conflicts with the current main branch. Its build/release changes have already been superseded by later repository cleanup and runtime fixes. Closed without merge to avoid reintroducing stale generated files, duplicated workflow configuration, and outdated deployment instructions.

qwen-intl added 2 commits May 19, 2026 11:36
- 更新 GitHub Actions 使用最新版本 (v4/v5)
- Windows 构建包含 README 和 LICENSE 文件
- Linux 构建包含完整文档
- 自动生成精美的 Release 说明
- 支持手动触发和标签触发两种方式
- 优化的 PyInstaller 配置,正确包含所有模块
- NEXT_STEPS.md: Create comprehensive GitHub deployment guide with CI/CD workflow instructions, repository setup steps, and troubleshooting guides
- .gitignore: Update ignore patterns with expanded build artifacts, compressed files, and improved directory exclusions

The changes provide clear deployment instructions for GitHub release automation and enhance file exclusion patterns for better project cleanliness.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6857c8cf99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +164 to +167
with:
name: 自动点击器专业版 ${{ steps.get_version.outputs.version }}
body_path: changelog.md
files: |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire manual releases to the requested tag

When this workflow is run via workflow_dispatch, the entered version is only used in the release title/body; softprops/action-gh-release documents tag_name as defaulting to the triggering ref (github.ref_name/GITHUB_REF), and GitHub documents workflow_dispatch as running on the selected branch or tag. As a result, using the advertised manual flow from main will create/update a release for main rather than the requested v1.0.0, so the uploaded binaries are attached to the wrong release unless the user manually dispatches from an existing tag. Pass tag_name: ${{ steps.get_version.outputs.version }} (and appropriate target_commitish) here.

Useful? React with 👍 / 👎.

Comment on lines +162 to +164
- name: Create Release
uses: softprops/action-gh-release@v1
with:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Grant release job write permission

In repositories or organizations where the default GITHUB_TOKEN permission is read-only, this release step will fail with a permissions error because the workflow never requests write access. The softprops/action-gh-release documentation lists permissions: contents: write as required for the GitHub integration token, so add that at the workflow or create-release job level before calling the action.

Useful? React with 👍 / 👎.

@2002yy 2002yy closed this Aug 4, 2026
2002yy added a commit that referenced this pull request Aug 22, 2026
第四轮审计修复:
- P0 修复 StatusBar 引用未导入常量导致的启动崩溃;新增 GUI 冒烟测试纳入 CI 防回归
- 键盘宏支持修饰键组合:Ctrl+C 录为单条 chord 动作并整体还原,Shift+单击同样支持
- 回放改为按录制时间戳原速执行(全零时间戳旧文件退回固定间隔)
- 修复拖拽被 hold_duration 拆碎:press/release 按 (kind,target) 配对
- 引擎状态改结构化 EngineEvent 枚举驱动 UI 状态机;stop_recording 加锁幂等

新功能(Roadmap #1/#2):
- 宏编辑:删除选中/上移/下移/清空,引擎提供线程安全序列编辑方法
- 快捷键自定义:四键均可改(支持组合键),settings.json 持久化,录制跳过集合同步更新避免自定义控制键被误录

附带修复:
- Tk 变量残留导致进程退出 Tcl_AsyncDelete 崩溃(显式 master + on_close 主动回收)
- HotkeyManager 回调异常在子线程内捕获,不再刷 traceback
- 销毁后残留 after 回调的 Tcl 后台错误(受管定时器 + on_close 统一取消)

测试 62 -> 101 项全部通过;README 功能清单与 Roadmap 同步更新
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants