DSV4 NNX support#4497
Open
snehalv2002 wants to merge 2 commits into
Open
Conversation
snehalv2002
force-pushed
the
dsv4-bug-fixes
branch
6 times, most recently
from
July 16, 2026 23:15
0d18a3e to
7f4b99f
Compare
…e.py, and match maxtext sinkhorn implementation to HF reference.
snehalv2002
force-pushed
the
dsv4-bug-fixes
branch
from
July 16, 2026 23:15
7f4b99f to
aee748b
Compare
snehalv2002
force-pushed
the
dsv4-nnx-support
branch
from
July 17, 2026 19:55
5842e03 to
a755efd
Compare
snehalv2002
marked this pull request as ready for review
July 17, 2026 19:56
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
snehalv2002
requested review from
NicoGrande,
NuojCheng,
RissyRan,
abhinavclemson,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xibinliu
as code owners
July 17, 2026 19:56
snehalv2002
requested review from
A9isha,
SurbhiJainUSC,
darisoy,
dipannita08,
hengtaoguo and
igorts-git
as code owners
July 17, 2026 19:56
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
snehalv2002
force-pushed
the
dsv4-bug-fixes
branch
from
July 17, 2026 23:43
aee748b to
2d1c867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds DeepSeek V4 (
DEEPSEEK4) decoder block support and HyperHead routing integration toNNXDecoder.Context & Implementation Details
DeepSeek4HyperHeadonNNXDecoderwhenmhc_expansion_rate > 1anddecoder_block == DecoderBlockType.DEEPSEEK4.NNXDecoderthroughself.hc_head(y)forDEEPSEEK4instead of the defaultmhc_reduce(y).DecoderBlockType.DEEPSEEK4to the list of supported decoder block types inNNXDecoder.Tests
test_nnx_decoder_hyperhead_integrationintests/unit/deepseek_v4_vs_reference_test.pyto verifyNNXDecoderinitializeshc_headasDeepSeek4HyperHead.pytest tests/unit/deepseek_v4_vs_reference_test.py.Checklist
gemini-reviewlabel.