[WIP] Weight Sync#4524
Open
YixuanWang-99 wants to merge 12 commits into
Open
Conversation
…direct_rules - Removed dead code build_torchax_rules() which is no longer needed. - Renamed build_maxtext_direct_rules() to build_converter_rules() to better reflect its function mapping structural geometry rather than a direct copy
…Converter (syncing directly into engine)
YixuanWang-99
requested review from
RissyRan,
abhinavclemson,
bvandermoon,
gobbleturk,
khatwanimohit and
vipannalla
as code owners
July 17, 2026 18:51
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
YixuanWang-99
requested review from
A9isha,
NuojCheng,
SurbhiJainUSC,
aireenmei,
darisoy,
dipannita08,
gagika,
hengtaoguo,
igorts-git,
jiangjy1982,
richjames0,
shralex and
suexu1025
as code owners
July 17, 2026 18:51
YixuanWang-99
commented
Jul 17, 2026
| vllm_config = pyconfig.initialize(argv_list) | ||
|
|
||
| rl_rollout_engine = ( | ||
| functools.partial(MaxTextVllmRollout, maxtext_config=trainer_config) |
Collaborator
Author
There was a problem hiding this comment.
check if this engine still works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
You can also provide a comma-separated list. If you don't want to close a bug but
simply to reference it, use BUGS, e.g.:
BUGS: b/123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.