-
Notifications
You must be signed in to change notification settings - Fork 20
Add install test without toolchain #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
timokoessler
wants to merge
2
commits into
main
Choose a base branch
from
add-test-without-toolchain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Verifies that `pip install` for this package resolves purely to prebuilt | ||
| # wheels, with no source build required. Mirrors restricted runtimes such as | ||
| # the AWS Lambda Python base images, which don't ship a C toolchain. | ||
| FROM python:3.14-slim | ||
|
|
||
| WORKDIR /app | ||
| COPY . . | ||
|
|
||
| RUN pip install --no-cache-dir --only-binary=:all: . | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: 📦 Install without build toolchain | ||
| on: [push] | ||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| install: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Install dependencies in a container without a build toolchain | ||
| run: docker build -f .github/workflows/Dockerfile.install-toolchain-free -t aikido-zen-install-toolchain-free . |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium - Install check cannot pass because pytricia has no wheel
The image uses Python 3.14 on Linux, where the package's required
pytriciadependency is selected, but the repository lock records version 1.3.0 with only a source tarball. Because--only-binary=:all:forbids that distribution and the slim image has no compiler to build it, every run reaches pip's resolution error before installing the project, leaving this new workflow permanently red rather than providing a usable toolchain-free install check.Show fix
Provide and select a Linux/Python 3.14 wheel-capable replacement or release wheels for the required pytricia dependency before enforcing this check. If source builds are intentionally supported instead, remove the all-binary restriction and explicitly install the required build toolchain; otherwise use a dependency set that is actually satisfiable in the restricted image.
More info - Reply on this comment to give feedback or ignore the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is why we add a test for it. We will wait with merging this until we can enforce it.