Evtpool merger#15593
Open
jackal1-66 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A multi-threaded merger is created for the evtpool files (Kine files will work as well). Only the file reading is multi-worker based, while the writing is sequential. The development takes care of increasing the EventID in the MCEventHeader.
std::optionalis used in order to distinguish the cases in which a file is opened, succesfully read but it is empty (in this case an empty vector is returned), with the case in which the file is not read at all (a std::null_opt is returned in this other case) . In addition:--inputaccepts a mix of .root pool files and list files (local or alien://), one path per line, # comments, resolved recursively and protection against recursion (a files list cannot include itself).TJAlienConnectionManageris a non-reentrant singleton, and simultaneous Connect() calls corrupt its shared websocket/TLS state. This is not covered by ROOT::EnableThreadSafety() --> the open/connect step foralien://paths is serialized behind a mutex (gAlienOpenMutex); local files and the actual per-file tree reads after opening remain fully parallel.Should an example be generated as well? opened the PR to test full compatibility with CI, tested already locally and output tested with the help of @romainschotter