[OCTRL-1090] Create k8s client to allow deployment of custom CRDs programmatically#821
Open
justonedev1 wants to merge 2 commits into
Open
[OCTRL-1090] Create k8s client to allow deployment of custom CRDs programmatically#821justonedev1 wants to merge 2 commits into
justonedev1 wants to merge 2 commits into
Conversation
justonedev1
force-pushed
the
OCTRL-1090-clean
branch
2 times, most recently
from
d3e7ea3 to
0efbca9
Compare
justonedev1
force-pushed
the
OCTRL-1090-clean
branch
from
0efbca9 to
3aa1563
Compare
knopers8
previously approved these changes
Jul 3, 2026
| return config, nil | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("ECS isn't running in a container and you didn't pass any kubernetes config") |
Collaborator
There was a problem hiding this comment.
maybe it's worth to print also err?
Collaborator
Author
There was a problem hiding this comment.
I assume that logging is done by the user of the client. It might not be wanted behavior to log error multiple times (caller, and the client itself)
| * Intergovernmental Organization or submit itself to any jurisdiction. | ||
| */ | ||
|
|
||
| package client_test |
Collaborator
There was a problem hiding this comment.
not for this PR, but I would propose that the tests in control-operator are added to CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.