Skip to content

[PWGCF] Update in axis ranges for PID QA plots#16918

Draft
sustripathy wants to merge 5 commits into
AliceO2Group:masterfrom
sustripathy:master
Draft

[PWGCF] Update in axis ranges for PID QA plots#16918
sustripathy wants to merge 5 commits into
AliceO2Group:masterfrom
sustripathy:master

Conversation

@sustripathy

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 3, 2026
@github-actions github-actions Bot changed the title Update in axis ranges for PID QA plots [PWGCF] Update in axis ranges for PID QA plots Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#16918
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 12c221e at 2026-07-03 19:34:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 28 errors and 11 warnings.'
Found 28 errors and 11 warnings.
++ [[ 28 -gt 0 ]]
++ cat /sw/BUILD/ff132efbe0080e6ea39e4165cded651088034f6f/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:74:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:77:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:79:8: error: constructor does not initialize these fields: multCutFormulaParamIndex, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:128:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:175:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:403:10: error: constructor does not initialize these fields: multiplicity, zvtx [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:430:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:432:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:434:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:436:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:701:47: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:704:34: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:713:50: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:716:37: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:730:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:735:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:955:40: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:964:46: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:971:49: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1111:40: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1119:44: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1124:47: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1461:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1474:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1840:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2819:37: error: use designated initializer list to initialize 'ProxyCand' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2879:39: error: use designated initializer list to initialize 'ProtonCand' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2947:35: error: use designated initializer list to initialize 'KaonCand' [modernize-use-designated-initializers,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/ff132efbe0080e6ea39e4165cded651088034f6f/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:427:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:430:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:432:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:434:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:436:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:505:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1472:107: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1474:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1576:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1579:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:3011:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 28 -gt 0 ]]
[0 more errors; see full log]

Full log here.

@sustripathy
sustripathy marked this pull request as draft July 3, 2026 17:39
@alibuild

alibuild commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fe0e496 at 2026-07-03 19:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 27 errors and 11 warnings.'
Found 27 errors and 11 warnings.
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/a4cc2031fc2d5a0780f30bd1a0e115d48cf1c500/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:74:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:77:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:79:8: error: constructor does not initialize these fields: multCutFormulaParamIndex, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:128:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:175:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:430:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:432:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:434:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:436:11: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:701:47: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:704:34: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:713:50: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:716:37: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:730:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:735:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:955:40: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:964:46: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:971:49: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1111:40: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1119:44: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1124:47: error: use designated initializer list to initialize 'SimpleTrack' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1461:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1474:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1839:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2818:37: error: use designated initializer list to initialize 'ProxyCand' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2878:39: error: use designated initializer list to initialize 'ProtonCand' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:2946:35: error: use designated initializer list to initialize 'KaonCand' [modernize-use-designated-initializers,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/a4cc2031fc2d5a0780f30bd1a0e115d48cf1c500/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:427:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:430:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:432:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:434:67: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:436:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:505:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1472:107: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1474:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1576:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:1579:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/nucleibalance.cxx:3010:31: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 27 -gt 0 ]]
++ exit 1
[0 more errors; see full log]

Full log here.

@sustripathy
sustripathy marked this pull request as ready for review July 16, 2026 18:22
@sustripathy
sustripathy marked this pull request as draft July 16, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants