Skip to content

[PWGLF] Modified secondary particles selections in deuteronInTriggeredEvents.cxx#17008

Open
Cristian-Moscatelli wants to merge 2 commits into
AliceO2Group:masterfrom
Cristian-Moscatelli:deutInJets
Open

[PWGLF] Modified secondary particles selections in deuteronInTriggeredEvents.cxx#17008
Cristian-Moscatelli wants to merge 2 commits into
AliceO2Group:masterfrom
Cristian-Moscatelli:deutInJets

Conversation

@Cristian-Moscatelli

Copy link
Copy Markdown
Contributor

I modified the task PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx.

The main changes are:

  • Added the configurable triggerList to work with skimmed datasets (line 334);
  • Added a configurable to select if Zorro is used only for trigger accounting or also for selecting events based on the configured trigger list (line 335);
  • Applied the TPC selection before filling the TOF mass distributions (line 876).

The main revision concerns the candidate flagging procedure in processMC. In the updated version, particles are flagged as secondaries from weak decays when the condition particle.getProcess() == TMCProcess::kPDecay is satisfied. Secondaries from material are identified by selecting particles that are neither primary nor produced by weak decays.

@github-actions github-actions Bot added the pwglf label Jul 10, 2026
@github-actions github-actions Bot changed the title Modified secondary particles selections in deuteronInTriggeredEvents.cxx [PWGLF] Modified secondary particles selections in deuteronInTriggeredEvents.cxx Jul 10, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 30 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7e11981 at 2026-07-11 00:27:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 74 errors and 30 warnings.'
Found 74 errors and 30 warnings.
++ [[ 74 -gt 0 ]]
++ cat /sw/BUILD/212710b5fc1fc37de66e3d4eadd639418050a722/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:93:1: error: included header stdexcept is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:137:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:143:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:149:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:155:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:161:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:167:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:173:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:180:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:181:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:182:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:196:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:196:7: error: variable 'pidCuts' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:200:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:200:22: error: variable 'hNsigma' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:201:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:201:22: error: variable 'hTOFmass' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:202:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:202:22: error: variable 'hGenNuclei' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:203:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:203:22: error: variable 'hMomRes' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:204:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:204:22: error: variable 'hNsigmaEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:205:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:205:22: error: variable 'hTOFmassEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:206:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:206:22: error: variable 'hDCAxy' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:207:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:207:22: error: variable 'hDCAz' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:208:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:208:22: error: variable 'hGloTOFtracks' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:209:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:209:22: error: variable 'hDeltaP' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:210:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:210:28: error: variable 'hDCAHists' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:211:27: error: variable 'lut' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:211:27: error: variable 'lut' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:213:31: error: variable 'candidates' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:232:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:251:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:278:58: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/deuteronInTriggeredEvents.cxx:290:70: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants