Skip to content

[PWGCF] EbyE finalized errors on moments using subsampling#17018

Open
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling
Open

[PWGCF] EbyE finalized errors on moments using subsampling#17018
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling

Conversation

@baasingh

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 11, 2026
@github-actions github-actions Bot changed the title PWGCF: EbyE finalized errors on moments using subsampling [PWGCF] EbyE finalized errors on moments using subsampling Jul 11, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4299406 at 2026-07-11 08:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 6 warnings.'
Found 13 errors and 6 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:7: error: variable 'tmpFqErr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:57:7: error: variable 'collisionZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:58:8: error: constructor does not initialize these fields: pdg, binningM, fqEvent, fqEventSampled, binConEvent, binConEventSampled [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:170:16: error: member 'dcaxyMaxTrackPar0' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:171:16: error: member 'dcaxyMaxTrackPar1' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:172:16: error: member 'dcaxyMaxTrackPar2' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:173:16: error: member 'dcazMaxTrack' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:206:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:289:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:42: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:73: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:544:10: error: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:390:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:392:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:394:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:470:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:472:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:474:47: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants