Skip to content

[PWGEM/Dilepton] remove unused table#17020

Open
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:cleanup
Open

[PWGEM/Dilepton] remove unused table#17020
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:cleanup

Conversation

@dsekihat

@dsekihat dsekihat commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] remove unused table

@github-actions

github-actions Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 126 errors, ⚠️ 82 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) July 11, 2026 11:21
alibuild
alibuild previously approved these changes Jul 11, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

alibuild commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 37c6942 at 2026-07-11 13:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 17 errors and 0 warnings.'
Found 17 errors and 0 warnings.
++ [[ 17 -gt 0 ]]
++ cat /sw/BUILD/928ec9bdf68f10076d0122fb917f17799a43314d/O2Physics-code-check/errors.txt
PWGEM/Dilepton/DataModel/dileptonTables.h:54:12: error: no header providing "std::unordered_map" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:54:31: error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:498:32: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:687:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:702:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:717:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:57:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:66:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:124:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:162:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:163:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:163:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:164:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:271:65: error: the parameter 'fwdtrack' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:359:14: error: unused variable 'mcParticle_MCHMID' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:360:14: error: unused variable 'mcParticle_MFT' [clang-diagnostic-unused-variable,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:366:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 17 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
Refactor mcParticle assignments in skimmerPrimaryMuon
d450f22 
Commented out redundant mcParticle assignments for clarity.
@dsekihat dsekihat disabled auto-merge July 11, 2026 13:44
@dsekihat dsekihat enabled auto-merge (squash) July 11, 2026 13:52
alibuild
alibuild approved these changes Jul 11, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@alibuild

alibuild commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d450f22 at 2026-07-11 16:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 15 errors and 0 warnings.'
Found 15 errors and 0 warnings.
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/ab0f79abebd344918ae98b17520d07e750d5aa8b/O2Physics-code-check/errors.txt
PWGEM/Dilepton/DataModel/dileptonTables.h:54:12: error: no header providing "std::unordered_map" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:54:31: error: no header providing "std::string" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:498:32: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:687:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:702:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/DataModel/dileptonTables.h:717:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:57:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:66:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:124:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:162:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:163:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:163:39: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:164:24: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:271:65: error: the parameter 'fwdtrack' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx:366:17: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 15 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

Assignees

No one assigned

Labels

datamodel pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsekihat @alibuild