Skip to content

[PWGDQ] Add J/psi-muon correlations task#17059

Open
kaareendrup wants to merge 24 commits into
AliceO2Group:masterfrom
kaareendrup:JPsiMuonCorrelations
Open

[PWGDQ] Add J/psi-muon correlations task#17059
kaareendrup wants to merge 24 commits into
AliceO2Group:masterfrom
kaareendrup:JPsiMuonCorrelations

Conversation

@kaareendrup

@kaareendrup kaareendrup commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Simple task to produce correlations between dimuon J/Psi candidates and single muons in the way of PWGDQ-130

@github-actions github-actions Bot added the pwgdq label Jul 14, 2026
@github-actions github-actions Bot changed the title J psi muon correlations [PWGDQ] J psi muon correlations Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 24 errors, ⚠️ 11 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 502cc26 at 2026-07-14 22:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 9 errors and 0 warnings.'
Found 9 errors and 0 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/48154ab480ae762c0b307003e37514d695a20766/O2Physics-code-check/errors.txt
PWGDQ/Tasks/taskJPsiMu.cxx:14:1: error: included header AnalysisCompositeCut.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:15:1: error: included header AnalysisCut.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:24:1: error: included header BinningPolicy.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:29:1: error: included header StringHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:32:1: error: included header types.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:34:1: error: included header RtypesCore.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:39:1: error: included header memory is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:81:8: error: constructor does not initialize these fields: ccdb, fValuesDilepton, fValuesMuon [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:272:8: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 9 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 670d426 at 2026-07-16 04:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/b72879ecaf8fc3a3e1e7fb742171b182cc11cd5f/O2Physics-code-check/errors.txt
PWGDQ/Tasks/taskJPsiMu.cxx:72:8: error: constructor does not initialize these fields: ccdb, fValuesDilepton, fValuesMuon [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Tasks/taskJPsiMu.cxx:263:23: error: loop variable has narrower type 'uint8_t' than iteration's upper bound 'size_type' [bugprone-too-small-loop-variable,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Comment on lines +112 to +113
float* fValuesDilepton;
float* fValuesMuon;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use raw pointers. Why do you even need pointers here?

Comment on lines +130 to +131
fValuesDilepton = new float[VarManager::kNVars];
fValuesMuon = new float[VarManager::kNVars];

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these deleted?

@vkucera vkucera changed the title [PWGDQ] J psi muon correlations [PWGDQ] Add J/psi-muon correlations task Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants