Skip to content

[PWGCF] FU: fixing histos for prompt fraction; process to store only reco events in MC truth#17064

Merged
majanik merged 2 commits into
AliceO2Group:masterfrom
kgwizdzi:femtoUni20260714
Jul 15, 2026
Merged

[PWGCF] FU: fixing histos for prompt fraction; process to store only reco events in MC truth#17064
majanik merged 2 commits into
AliceO2Group:masterfrom
kgwizdzi:femtoUni20260714

Conversation

@kgwizdzi

Copy link
Copy Markdown
Contributor

Changes in femtoUniverseProducerMCTruthTask.cxx:

  • new process function which store only the MC Truth events which are reconstructed - processTrackMcOnlyRecoColl
  • new function to check the reconstructed collisions - checkMcRecoCollisions
  • possibility to store PDG code of mother particle - confStoreMotherPDG
  • fixing clang-tidy errors/warnings

Changes in femtoUniversePairTaskTrackD0.cxx:

  • new configurables to set the nSigma TPC and combined values separately
  • unused configurables removed
  • unused process functions removed
  • possibility to cut on the non-prompt score when selecting the D0 candidates added
  • nSigma histograms' ranges fixed
  • new THnSparse for D0 and D0bar candidates added (implemented for prompt fraction estimation)
  • clang-tidy errors/warnings fixed

@github-actions github-actions Bot added the pwgcf label Jul 14, 2026
@github-actions github-actions Bot changed the title FU: fixing histos for prompt fraction; process to store only reco events in MC truth [PWGCF] FU: fixing histos for prompt fraction; process to store only reco events in MC truth Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 990e78f at 2026-07-14 18:59:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 0 warnings.'
Found 13 errors and 0 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/18cf69d2e64e8e8ba7fa249f431dc35a1db9e9fc/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx:188:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx:194:33: error: the parameter 'particle' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx:198:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx:203:12: error: the variable 'motherparticleMC' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerMCTruthTask.cxx:310:17: error: no header providing "std::set" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:319:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:340:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:361:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:787:11: error: variable 'tpcNSigmaPr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:787:24: error: variable 'tofNSigmaPr' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:787:37: error: variable 'tpcNSigmaPi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:787:50: error: variable 'tofNSigmaPi' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackD0.cxx:787:63: error: variable 'tpcNSigmaKa' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

@kgwizdzi kgwizdzi marked this pull request as draft July 14, 2026 17:32
@kgwizdzi kgwizdzi marked this pull request as ready for review July 15, 2026 12:07
@majanik majanik enabled auto-merge (squash) July 15, 2026 14:03
@majanik majanik merged commit 867a9d4 into AliceO2Group:master Jul 15, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants