Skip to content

[PWGEM] Adding the possibility to reject a radial region in PCM#17079

Merged
mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
amaringarcia:master
Jul 16, 2026
Merged

[PWGEM] Adding the possibility to reject a radial region in PCM#17079
mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
amaringarcia:master

Conversation

@amaringarcia

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Jul 15, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 359 errors, ⚠️ 608 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Adding the possibility to reject a radial region in PCM [PWGEM] Adding the possibility to reject a radial region in PCM Jul 15, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 423495c at 2026-07-16 04:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 73 errors and 7 warnings.'
Found 73 errors and 7 warnings.
++ [[ 73 -gt 0 ]]
++ cat /sw/BUILD/489dba3b73d58e6733b6dd2815e99a2b766a6199/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:77:8: error: constructor does not initialize these fields: f1fd_k0s_to_pi0, ccdb, mRunNumber, d_bz [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:235:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:294:39: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:295:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:318:23: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:373:14: error: variable 'mCentralityTypeMlEnum' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:600:13: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGammaMC.h:954:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:81:8: error: constructor does not initialize these fields: ccdb, mRunNumber, d_bz, emcalGeom [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:438:39: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:439:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:462:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:464:12: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:525:14: error: variable 'mCentralityTypeMlEnum' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:620:86: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:696:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:735:13: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h:773:39: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.cxx:77:23: error: parameter 'psiDepCut' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.cxx:212:20: error: parameter 'ptDepCut' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:49:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:67:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:81:44: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:81:52: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:83:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:96:46: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:96:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:103:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:104:41: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:104:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:107:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:217:3: error: return type 'const std::string' (aka 'const basic_string<char>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:218:3: error: return type 'const std::string' (aka 'const basic_string<char>') is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:310:18: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:340:18: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:846:9: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:856:9: error: if with identical then and else branches [bugprone-branch-clone,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:930:13: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:1021:116: error: redundant explicit casting to the same type 'int' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:1067:3: error: return type 'const std::span<float>' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:1158:8: error: function 'V0PhotonCut::SetNamesInputFeatures' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name,-warnings-as-errors]
PWGEM/PhotonMeson/Core/V0PhotonCut.h:1181:48: error: initializer for member 'mMaxMeePsiPairDep' is redundant [readability-redundant-member-init,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@mhemmer-cern mhemmer-cern merged commit 4ba6045 into AliceO2Group:master Jul 16, 2026
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants