Skip to content

[Common] Preserve fatalWhenNull state in PIDTOFParamService#17145

Merged
dsekihat merged 1 commit into
masterfrom
romainschotter-patch-1-1
Jul 21, 2026
Merged

[Common] Preserve fatalWhenNull state in PIDTOFParamService#17145
dsekihat merged 1 commit into
masterfrom
romainschotter-patch-1-1

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator
  • put fatalWhenNull back to its initial value instead of true

@singhra1994 this should fix the crash in your train.

@njacazio for your information

@github-actions github-actions Bot changed the title Preserve fatalWhenNull state in PIDTOFParamService [Common] Preserve fatalWhenNull state in PIDTOFParamService Jul 21, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@romainschotter
romainschotter marked this pull request as ready for review July 21, 2026 09:47
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9c38006 at 2026-07-21 11:55:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9c38006 at 2026-07-21 12:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 0 warnings.'
Found 7 errors and 0 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/ad5dcb8204bb6ea0cac6ebdb1026085f13774d87/O2Physics-code-check/errors.txt
Common/Core/PID/PIDTOFParamService.cxx:49:116: error: the const qualified parameter 'task' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:73:65: error: the const qualified parameter 'task' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:137:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:215:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:288:8: error: destructor of 'TOFSupport' is public and non-virtual [cppcoreguidelines-virtual-class-destructor,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:297:29: error: use designated initializer list to initialize 'ServiceHandle' [modernize-use-designated-initializers,-warnings-as-errors]
Common/Core/PID/PIDTOFParamService.cxx:301:22: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@dsekihat
dsekihat merged commit 233332b into master Jul 21, 2026
14 of 17 checks passed
@dsekihat
dsekihat deleted the romainschotter-patch-1-1 branch July 21, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants