Skip to content

[PWGLF] added axis on nsigma histograms for purity as a function of centrality#17171

Open
GiorgioAlbertoLucia wants to merge 3 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:li4
Open

[PWGLF] added axis on nsigma histograms for purity as a function of centrality#17171
GiorgioAlbertoLucia wants to merge 3 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:li4

Conversation

@GiorgioAlbertoLucia

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 9 errors, ⚠️ 7 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia
GiorgioAlbertoLucia marked this pull request as ready for review July 23, 2026 08:15
@alibuild

alibuild commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7bb5c29 at 2026-07-23 10:59:

## sw/BUILD/O2Physics-latest/log
2026-07-23T10:50:09.968+0200 [24:140507782810176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:09.968+0200 [24:140507782810176] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-23T10:50:47.981+0200 [24:140507782810176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.227+0200 [23:140336681335360] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.228+0200 [23:140336681335360] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-23T10:50:54.996+0200 [23:140336681335360] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.150+0200 [26:139883141544512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.151+0200 [26:139883141544512] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-23T10:51:30.382+0200 [26:139883141544512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.622+0200 [25:139733142846016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-23T10:50:10.622+0200 [25:139733142846016] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-07-23T10:52:28.936+0200 [25:139733142846016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv6:%5B::1%5D:8980: Failed to connect to remote host: Connection refused]


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 26 errors and 11 warnings.'
Found 26 errors and 11 warnings.
++ [[ 26 -gt 0 ]]
++ cat /sw/BUILD/23e6ecbfcf9d9f882a7a2bee0c3598e0ea1966db/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:153:39: error: 'kItsParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:156:39: error: 'kBetheBlochParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:159:39: error: 'kBetheBlochCorrectionParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:169:39: error: 'kDCAResParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:178:3: error: function 'recoPtHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:179:3: error: function 'recoPhiHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:180:3: error: function 'recoEtaHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:181:3: error: function 'recoPtHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:182:3: error: function 'recoPhiHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:183:3: error: function 'recoEtaHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:249:8: error: constructor does not initialize these fields: mCcdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:285:85: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:336:10: error: constructor does not initialize these fields: itsParams, dcaxyResParams, dcazResParams [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:499:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:500:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:559:59: error: conditional operator with identical true and false expressions [bugprone-branch-clone,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:569:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:598:5: error: uninitialized record type: 'parameters' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:619:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:670:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:819:7: error: uninitialized record type: 'dcaInfo' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1169:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1250:20: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1250:71: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1257:20: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1257:79: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
[0 more errors; see full log]

Full log here.

@maciacco
maciacco enabled auto-merge (squash) July 23, 2026 10:30
@alibuild

alibuild commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c26c8bf at 2026-07-23 13:37:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 25 errors and 11 warnings.'
Found 25 errors and 11 warnings.
++ [[ 25 -gt 0 ]]
++ cat /sw/BUILD/34952b97b4e5eaa1e959e6d9080d11aedc05afda/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:153:39: error: 'kItsParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:156:39: error: 'kBetheBlochParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:159:39: error: 'kBetheBlochCorrectionParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:169:39: error: 'kDCAResParNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:178:3: error: function 'recoPtHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:179:3: error: function 'recoPhiHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:180:3: error: function 'recoEtaHe3' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:181:3: error: function 'recoPtHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:182:3: error: function 'recoPhiHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:183:3: error: function 'recoEtaHad' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:249:8: error: constructor does not initialize these fields: mCcdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:286:85: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:337:10: error: constructor does not initialize these fields: itsParams, dcaxyResParams, dcazResParams [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:500:5: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:501:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:570:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:599:5: error: uninitialized record type: 'parameters' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:620:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:671:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:820:7: error: uninitialized record type: 'dcaInfo' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1170:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1251:20: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1251:71: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1258:20: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1258:79: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/34952b97b4e5eaa1e959e6d9080d11aedc05afda/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:578:62: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:590:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:619:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:790:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1304:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1309:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1335:184: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1356:58: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1361:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1365:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1393:129: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 25 -gt 0 ]]
++ exit 1
--

[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiorgioAlbertoLucia @alibuild @maciacco