Skip to content

[PWGLF] Rename source file nucleitpcpbpb.cxx to nucleitpcPbPb.cxx and clean the code with few changes#17177

Merged
maciacco merged 7 commits into
AliceO2Group:masterfrom
jtanwar2212:master
Jul 23, 2026
Merged

[PWGLF] Rename source file nucleitpcpbpb.cxx to nucleitpcPbPb.cxx and clean the code with few changes#17177
maciacco merged 7 commits into
AliceO2Group:masterfrom
jtanwar2212:master

Conversation

@jtanwar2212

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Rename source file nucleitpcpbpb.cxx to nucleitpcPbPb.cxx and clean the code with few changes [PWGLF] Rename source file nucleitpcpbpb.cxx to nucleitpcPbPb.cxx and clean the code with few changes Jul 23, 2026
Please consider the following formatting changes to AliceO2Group#17177
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6944cff at 2026-07-23 10:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 107 warnings.'
Found 14 errors and 107 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/024e391bfcf546cae1c72c65cc29c9426c98e73b/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:151:8: error: use default member initializer for 'active' [modernize-use-default-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:156:5: error: 'resolution' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:165:35: error: variable 'hmass' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:166:35: error: variable 'hmassnsigma' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:171:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:282:15: error: member 'proton' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:283:15: error: member 'de' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:284:15: error: member 'triton' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:285:15: error: member 'he3' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:286:15: error: member 'he4' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:703:33: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:979:10: error: variable 'insideDCAxy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:987:10: error: variable 'insideDCAz' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:1248:47: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 107 -gt 0 ]]
++ cat /sw/BUILD/024e391bfcf546cae1c72c65cc29c9426c98e73b/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:405:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:407:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:411:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:414:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:418:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:425:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:432:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:436:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:441:109: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:446:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:449:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:451:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:455:123: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:457:123: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:487:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:511:142: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:563:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:565:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:567:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:569:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:571:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:573:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:578:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:585:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:594:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:596:45: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@maciacco
maciacco enabled auto-merge (squash) July 23, 2026 10:18
@maciacco
maciacco merged commit d5e065d into AliceO2Group:master Jul 23, 2026
13 of 14 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9589131 at 2026-07-23 16:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 107 warnings.'
Found 13 errors and 107 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/e2431ae2968d6689c8ff11f22c59fce7d75319e4/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:151:8: error: use default member initializer for 'active' [modernize-use-default-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:156:5: error: 'resolution' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:165:35: error: variable 'hmass' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:166:35: error: variable 'hmassnsigma' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:171:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:282:15: error: member 'proton' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:283:15: error: member 'he3' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:284:15: error: member 'he4' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:701:33: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:977:10: error: variable 'insideDCAxy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:985:10: error: variable 'insideDCAz' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:1064:9: error: variable 'decayType' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:1246:47: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 107 -gt 0 ]]
++ cat /sw/BUILD/e2431ae2968d6689c8ff11f22c59fce7d75319e4/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:403:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:405:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:409:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:412:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:416:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:423:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:430:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:434:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:439:109: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:444:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:447:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:449:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:453:123: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:455:123: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:485:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:509:142: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:561:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:563:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:565:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:567:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:569:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:571:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:576:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:583:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:592:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:594:45: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Nuspex/nucleitpcPbPb.cxx:598:43: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants