Skip to content

[PWGCF] FemtoUniverse - Track-Phi - new PID for Phi#17187

Open
zchochul wants to merge 2 commits into
AliceO2Group:masterfrom
zchochul:PR_23.07.2026
Open

[PWGCF] FemtoUniverse - Track-Phi - new PID for Phi#17187
zchochul wants to merge 2 commits into
AliceO2Group:masterfrom
zchochul:PR_23.07.2026

Conversation

@zchochul

Copy link
Copy Markdown
Collaborator

Trying new PID for Kaons (taken from Veronika Barbasova's AN (https://alice-notes.web.cern.ch/node/1758).

@github-actions github-actions Bot added the pwgcf label Jul 23, 2026
@github-actions github-actions Bot changed the title FemtoUniverse - Track-Phi - new PID for Phi [PWGCF] FemtoUniverse - Track-Phi - new PID for Phi Jul 23, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 84 errors, ⚠️ 44 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 738e942 at 2026-07-23 19:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 46 errors and 3 warnings.'
Found 46 errors and 3 warnings.
++ [[ 46 -gt 0 ]]
++ cat /sw/BUILD/b549ca69eeba98dbb6d260a483e86a36f0a8cf35/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:64:39: error: 'partNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:65:39: error: 'cutNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:71:8: error: constructor does not initialize these fields: pdgMC [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:219:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:220:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:225:16: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:226:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:239:75: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:241:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:256:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:257:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:264:20: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:265:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:271:20: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:272:13: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:284:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:285:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:290:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:291:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:296:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:297:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:310:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:311:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:323:60: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:325:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:330:75: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:332:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:344:9: error: redundant boolean literal in if statement condition [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:347:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:348:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:353:18: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:354:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:365:59: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:367:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:372:73: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:374:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:535:34: error: the parameter 'groupPartsTrack' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:535:65: error: the parameter 'groupPartsPhi' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:535:89: error: the parameter 'parts' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:535:159: error: the parameter 'mcParts' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:663:35: error: the parameter 'groupPartsTrack' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:663:66: error: the parameter 'groupPartsPhi' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7a40200 at 2026-07-25 00:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 3 warnings.'
Found 13 errors and 3 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/d3a68bf50d8903115cdc97496907fba0f390a0ca/O2Physics-code-check/errors.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:219:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:232:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:242:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:246:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:258:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:279:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:286:9: error: redundant boolean literal in if statement condition [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:289:9: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:303:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:459:180: error: the parameter 'mcParts' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:587:181: error: the parameter 'mcParts' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:698:11: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:720:11: error: do not use 'else' after 'continue' [readability-else-after-return,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d3a68bf50d8903115cdc97496907fba0f390a0ca/O2Physics-code-check/warnings.txt
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:678:95: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:734:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:749:362: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants