[OGUI-1203] More sophisticated multiline selection - #3584
Draft
isaachilly wants to merge 12 commits into
Draft
Conversation
isaachilly
changed the title
isaachilly
changed the base branch from
dev
to
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
August 20, 2026 19:24
isaachilly
force-pushed
the
feature/ILG/OGUI-1203/Multiline-selection
branch
from
August 20, 2026 19:25
124b305 to
501f9a8
Compare
isaachilly
force-pushed
the
feature/ILG/OGUI-1203/Multiline-selection
branch
from
August 21, 2026 09:28
501f9a8 to
2568fad
Compare
isaachilly
force-pushed
the
feature/ILG/OGUI-1203/Multiline-selection
branch
from
August 21, 2026 15:10
c182509 to
97fc2cb
Compare
Base automatically changed from
bug/ILG/OGUI-1903/Copy-select-has-new-lines-issue
to
dev
August 24, 2026 15:37
Introduce a dedicated `LogSelection` model to manage log selection due to the added complexity. * `Log.item` is now derived from selection focus * Selection is preserved or shifted correctly when logs are trimmed in live mode * Table rendering now passes real list indexes for viewport rows. * Ctrl/Cmd+C now copies all selected log rows instead of only the current row.
Adjust the mocha tests to reset `window.model.log.item` directly due to new setter.
Make text selection in cells transparent to avoid unsightly appearance.
Allow users to extend log selection using Shift+Up/Down arrow keys.
Add selection-copy coverage: reset table/selection state, simulate drag selection across virtualised rows, and assert clipboard CSV output for all selected rows.
isaachilly
force-pushed
the
feature/ILG/OGUI-1203/Multiline-selection
branch
from
August 24, 2026 15:37
cbc53bd to
04b6b6d
Compare
Update keyboard selection behaviour so Shift+Up/Down extends from the current log index instead of requiring drag state. `extendTo` now works for active selections (not just dragging), so the user can drag and then decide to use the keys. Most importantly, disable auto-scroll when beginning a direct row selection to avoid unintended scrolling.
Wrap `extendTo` in an `onMouseMove` handler that checks `e.buttons === 1` and `isDragging` so selection only extends during actual mouse drags originating inside the table and not during keyboard interactions.
Adds a new test case verifying that keyboard-based selection works and is not overridden by subsequent mouse hover events.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created