Add option to change hole color when using compose version of PieChart - #817
Merged
hannesa2 merged 2 commits intoAug 5, 2026
Merged
Conversation
…t [PieChartComposable]. Also add example to the activity showcase
Contributor
Author
|
Screenshots: 
|
hannesa2
changed the title
Collaborator
|
As running from a fork, there are no screenshot tests. I made a copy of this to run CI from upstream to have screenshot compare mechanism |
hannesa2
requested changes
Aug 5, 2026
| add(ComposeItem("HorizontalCompose", "Render bar chart horizontally compose", HorizontalBarComposeActivity::class.java).toDemoBase()) | ||
| add(ComposeItem("HorizontalFullCompose", "Render bar chart horizontally full compose.", HorizontalBarFullComposeActivity::class.java).toDemoBase()) | ||
| add(ComposeItem("MultiLineCompose", "Show multiple data sets in compose.", MultiLineComposeActivity::class.java).toDemoBase()) | ||
| add(ComposeItem("PieChartCompose", "Render a pie chart in compose, incl. hole color.", PieChartComposeActivity::class.java).toDemoBase()) |
Collaborator
There was a problem hiding this comment.
Please move this sample to the end of the list, otherwise the screenshots are renamed and it will find too much errors
Contributor
Author
There was a problem hiding this comment.
is this enough or new section would be better? Feel free to edit
Collaborator
|
Now it looks better, just one new screenshot |
Collaborator
|
I'll merge it like it is and fix the missing screenshot after this. Thanks a lot ! |
Collaborator
|
This is the missing screenshot d6a5922 |
Contributor
Author
|
no problem, thanks for the quick action |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to change hole color when using compose version of PieChart [PieChartComposable].
Also add example to the activity showcase