Rebuild annotation overlay on demand in rdfae:show-overlay - #26
Merged
Conversation
The overlay is a render-once singleton, but a host that re-renders the page DOM (or disposes it as a Bootstrap modal, as LinkedDataHub does via its generic modal teardown) can remove it between invocations. show-overlay then passed an empty node to rdfae:show-at (element(), exactly one), throwing a SaxonJS cardinality error on the next right-click. Ensure the overlay exists before positioning it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The annotation overlay is a render-once singleton. A host that re-renders the page DOM — or disposes it as a Bootstrap modal, as LinkedDataHub does via its generic modal teardown — can remove the overlay between invocations.
rdfae:show-overlaythen passed an empty node tordfae:show-at(element(), exactly one), throwing a SaxonJS cardinality error on the next right-click.This rebuilds the overlay on demand:
show-overlaycallsrdfae:init-overlaywhenid($rdfae:overlay-id, ixsl:page())resolves to nothing, soshow-atalways has an element to position.Already mirrored into LinkedDataHub (
overlay.xslis byte-identical there, commit896288c8d).🤖 Generated with Claude Code