Skip to content

fix(mobile): uniform contest tile height in horizontal scroll row #14540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanjeffers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mobile): uniform contest tile height in horizontal scroll row #14540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aabd070
fix(mobile): uniform contest tile height in horizontal scroll row
dylanjeffers Jul 28, 2026
ed8cecf
fix(mobile): restore gap between contest skeleton cards in explore ca…
dylanjeffers Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/mobile/src/components/contest-card/ContestCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,17 @@ export const ContestCard = (props: ContestCardProps) => {
<Divider orientation='horizontal' />

<Flex direction='column' gap='s'>
<Text
variant='heading'
size={variant === 'hero' ? 'l' : 'm'}
numberOfLines={2}
>
{contestTitle}
</Text>
{/* minHeight reserves space for 2 lines of heading/m (lineHeight xl = 32px × 2)
so grid cards stay the same height whether the title wraps or not. */}
<View style={{ minHeight: variant === 'hero' ? undefined : 64 }}>
<Text
variant='heading'
size={variant === 'hero' ? 'l' : 'm'}
numberOfLines={2}
>
{contestTitle}
</Text>
</View>
<ScrollView
horizontal
showsHorizontalScrollIndicator={false}
Expand Down
4 changes: 1 addition & 3 deletions packages/mobile/src/screens/explore-screen/components/FeaturedRemixContests.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ export const FeaturedRemixContests = () => {
carouselSpacing={spacing.l}
horizontalCardWidth={contestCardWidth}
isLoading={isAllContestsPending}
LoadingCardComponent={() => (
<ContestCardSkeleton style={{ width: contestCardWidth }} />
)}
LoadingCardComponent={() => <ContestCardSkeleton />}
/>
</ExploreSection>
</InViewWrapper>
Expand Down