fix: keep acir unconstrained test builder valid - #24992
Draft
AztecBot wants to merge 1 commit into
Draft
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly debug build failed in
AcirComponentsCheckTest.DetectsUnconstrainedWitnessesbecause the test fixture simulated a missing circuit witness by shrinkingbuilder.real_variable_index. That leaves existing gate wires pointing past the end of the vector, so libstdc++ debug mode aborts beforeComponentsCheckercan report the intendedUNCONSTRAINEDerror.This keeps the builder internally consistent by building it from an empty circuit and using high ACIR witness IDs that are absent from that valid builder. The test still exercises the
UNCONSTRAINEDbranch without creating dangling gate references.Failed run: https://github.com/AztecProtocol/aztec-packages/actions/runs/30241948282
Testing
AVM=0 AVM_TRANSPILER=0 NATIVE_PRESET=debug cmake --build --preset debug --target acir_components_check_testsNATIVE_PRESET=debug barretenberg/cpp/scripts/run_test.sh acir_components_check_tests AcirComponentsCheckTest.DetectsUnconstrainedWitnesses./build-debug/bin/acir_components_check_testsCreated by claudebox · group:
slackbot· Slack thread