Skip to content

Support azdev test to auto cleanup pyc files and recordings when live test failed - #267

Open
Yalin Li (YalinLi0312) wants to merge 4 commits into
Azure:devfrom
AME-Redmond:dev-test
Open

Support azdev test to auto cleanup pyc files and recordings when live test failed#267
Yalin Li (YalinLi0312) wants to merge 4 commits into
Azure:devfrom
AME-Redmond:dev-test

Conversation

@YalinLi0312

@YalinLi0312 Yalin Li (YalinLi0312) commented Nov 12, 2020

Copy link
Copy Markdown

For issue #208

@YalinLi0312 Yalin Li (YalinLi0312) added the Test azdev test label Nov 12, 2020
@yonzhan

Yong Zhang (yonzhan) commented Nov 12, 2020

Copy link
Copy Markdown
Collaborator

Harold Ran (@haroldrandom) to help with.

@YalinLi0312

Yalin Li (YalinLi0312) commented Nov 30, 2020

Copy link
Copy Markdown
Author

Harold Ran (@haroldrandom) This PR is literally split out from previous big PR, it has addressed your comments there, and excludes the multi-process implementation. Do you have any new comments? Could we wrap up this week?

@qwordy

Feiyue Yu (qwordy) commented Dec 1, 2020

Copy link
Copy Markdown
Member

Does recording file have debug info that is useful?

@YalinLi0312

Yalin Li (YalinLi0312) commented Dec 1, 2020

Copy link
Copy Markdown
Author

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

@qwordy

Feiyue Yu (qwordy) commented Dec 2, 2020

Copy link
Copy Markdown
Member

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

This PR removes recording files when a test fails. Right? Is it possible that people need the recording files to debug?

Ren Silva (RenSilvaAU) pushed a commit to RenSilvaAU/azure-cli-dev-tools that referenced this pull request Aug 7, 2025
@necusjz
Merge pull request Azure#267 from necusjz/release-v1.5.0
08efb02 
Release v1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qwordy Feiyue Yu (qwordy) Awaiting requested review from qwordy
@jsntcy Yu Chen (jsntcy) Awaiting requested review from jsntcy
@yungezz Yunge Zhu (yungezz) Awaiting requested review from yungezz
@bquantump Steve Schilinski (bquantump) Awaiting requested review from bquantump
@yonzhan Yong Zhang (yonzhan) Awaiting requested review from yonzhan
@fengzhou-msft Feng Zhou (fengzhou-msft) Awaiting requested review from fengzhou-msft

At least 1 approving review is required to merge this pull request.

Assignees

@YalinLi0312 Yalin Li (YalinLi0312)

Labels

Test azdev test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YalinLi0312 @yonzhan @qwordy