[Resource] Point what-if noise notice to Deployment Stacks What-if with reduced noise - #33952
Open
Torrey Trahanovsky (torreymicrosoft) wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Torrey Trahanovsky (torreymicrosoft)
requested a review
from a team
as a code owner
August 21, 2026 15:55
|
Hi Torrey Trahanovsky (@torreymicrosoft), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
August 21, 2026 15:55
Copilot started reviewing on behalf of
Torrey Trahanovsky (torreymicrosoft)
August 21, 2026 15:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the template deployment what-if “noise” notice shown by az deployment ... what-if (and --confirm-with-what-if) by removing the older call-to-action that asked users to open an issue, leaving a single next step that points users to Deployment Stacks What-If.
Changes:
- Removed the
https://aka.ms/WhatIfIssuesissue-filing line from the_format_noise_noticeoutput. - Kept the existing “move to Deployment Stacks What-If” guidance as the sole follow-up action in the notice.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Resource |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
az deployment group what-if,az deployment sub what-if,az deployment mg what-if,az deployment tenant what-if(and the what-if preview shown by--confirm-with-what-if/-conaz deployment ... create).Description
Follow-up to #33943, which added a line pointing template deployment what-if users to Deployment Stacks What-if now that it is generally available.
This PR does two things:
What-ifcapitalization for both occurrences."Reduced noise" is the accurate claim: Stacks What-if filters noise against a baseline recorded when the stack was deployed, which substantially reduces false positives rather than eliminating them outright.
Before
After
Scope / risk
_format_noise_noticeinsrc/azure-cli/azure/cli/command_modules/resource/_formatters.py, reached solely throughformat_what_if_operation_resultfor template deployment what-if.DeploymentStacksWhatIfResultFormatterin_stacks_formatters.pyand is not touched.https://aka.ms/WhatIfIssueshas no remaining references undersrc/, so nothing is left orphaned.test_resource_changes_statsassertsresult.endswith(...)against the trailing resource-changes stats line, which is unaffected because the notice is emitted at the top of the output.pylintrcand.flake8.