Skip to content

[Resource] Point what-if noise notice to Deployment Stacks What-if with reduced noise - #33952

Open
Torrey Trahanovsky (torreymicrosoft) wants to merge 2 commits into
Azure:devfrom
torreymicrosoft:torreyt/whatif-remove-issues-line
Open

[Resource] Point what-if noise notice to Deployment Stacks What-if with reduced noise#33952
Torrey Trahanovsky (torreymicrosoft) wants to merge 2 commits into
Azure:devfrom
torreymicrosoft:torreyt/whatif-remove-issues-line

Conversation

@torreymicrosoft

@torreymicrosoft Torrey Trahanovsky (torreymicrosoft) commented Aug 21, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes Tests
️✔️ None ️✔️ 130/130

Related command

az deployment group what-if, az deployment sub what-if, az deployment mg what-if, az deployment tenant what-if (and the what-if preview shown by --confirm-with-what-if / -c on az deployment ... create).

Description

Follow-up to #33943, which added a line pointing template deployment what-if users to Deployment Stacks What-if now that it is generally available.

This PR does two things:

  1. Removes the older call to action, so the notice states the caveat and then gives a single next step that actually resolves it.
  2. Corrects the new line to say reduced noise rather than without noise, and uses consistent What-if capitalization for both occurrences.

"Reduced noise" is the accurate claim: Stacks What-if filters noise against a baseline recorded when the stack was deployed, which substantially reduces false positives rather than eliminating them outright.

Before

Note: The result may contain false positive predictions (noise).
You can help us improve the accuracy of the result by opening an issue here: https://aka.ms/WhatIfIssues
NOTICE! - Want to get What-if without noise? Move to Deployment Stacks What-If https://aka.ms/stackswhatifGA

After

Note: The result may contain false positive predictions (noise).
NOTICE! - Want to get What-if with reduced noise? Move to Deployment Stacks What-if https://aka.ms/stackswhatifGA

Scope / risk

  • The only change is the string literal in _format_noise_notice in src/azure-cli/azure/cli/command_modules/resource/_formatters.py, reached solely through format_what_if_operation_result for template deployment what-if.
  • Deployment Stacks what-if output is produced by DeploymentStacksWhatIfResultFormatter in _stacks_formatters.py and is not touched.
  • After this change https://aka.ms/WhatIfIssues has no remaining references under src/, so nothing is left orphaned.
  • No test asserts the notice text. test_resource_changes_stats asserts result.endswith(...) against the trailing resource-changes stats line, which is unaffected because the notice is emitted at the top of the output.
  • The notice line is 116 characters in source, within the 120-character limit configured in both pylintrc and .flake8.
  • The final string is byte-identical to the one used by the corresponding Azure PowerShell change ([Resources] Point what-if noise notice to Deployment Stacks What-if with reduced noise azure-powershell#30048).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 21, 2026 15:55
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Torrey Trahanovsky (@torreymicrosoft),
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Auto-Assign Auto assign by bot ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group act-identity-squad labels Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the template deployment what-if “noise” notice shown by az deployment ... what-if (and --confirm-with-what-if) by removing the older call-to-action that asked users to open an issue, leaving a single next step that points users to Deployment Stacks What-If.

Changes:

  • Removed the https://aka.ms/WhatIfIssues issue-filing line from the _format_noise_notice output.
  • Kept the existing “move to Deployment Stacks What-If” guidance as the sole follow-up action in the notice.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@torreymicrosoft Torrey Trahanovsky (torreymicrosoft) changed the title [Resource] Remove the WhatIfIssues line from the what-if noise notice [Resource] Point what-if noise notice to Deployment Stacks What-if with reduced noise Aug 21, 2026
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@yonzhan

Copy link
Copy Markdown
Collaborator

Resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-identity-squad ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants