Skip to content

Add managed identity support to EventGridOutput #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnab Nandy (arnabnandy7) wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add managed identity support to EventGridOutput #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/main/java/com/microsoft/azure/functions/annotation/EventGridOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,21 @@
* here: https://docs.microsoft.com/en-us/azure/event-grid/custom-event-quickstart#send-an-event-to-your-topic
* @return The topic key setting of the eventGrid topic.
*/
String topicKeySetting();
String topicKeySetting() default "";

/**
* Gets or sets the topic events endpoint URI. Eg: https://topic1.westus2-1.eventgrid.azure.net/api/events
* This is found in the Event Grid Topic's definition. You can find information on getting the Url for a topic
* here: https://docs.microsoft.com/en-us/azure/event-grid/custom-event-quickstart#send-an-event-to-your-topic
* @return The topic events endpoint URI of the eventGrid topic.
*/
String topicEndpointUri();
String topicEndpointUri() default "";

/**
* Defines the common prefix for app settings that configure an identity-based connection.
* When set, topicEndpointUri and topicKeySetting should not be set.
*
* @return The common prefix for the identity-based connection settings.
*/
String connection() default "";
}
7 changes: 7 additions & 0 deletions src/test/java/com/microsoft/azure/functions/annotation/BindingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ public void every_binding_annotation_should_have_dataType_method() {
}
}

@Test
public void event_grid_output_should_support_identity_based_connection() throws NoSuchMethodException {
assertEquals("", EventGridOutput.class.getMethod("connection").getDefaultValue());
assertEquals("", EventGridOutput.class.getMethod("topicEndpointUri").getDefaultValue());
assertEquals("", EventGridOutput.class.getMethod("topicKeySetting").getDefaultValue());
}

/**
* find all annotation bindings based on annotation suffix conventions defined in bindingAnnotationSuffix array
*/
Expand Down