This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Improved gps location device simulation - #159
Open
Joel Hulen (joelhulen) wants to merge 6 commits into
Open
Conversation
The previous version never actually changed the truck's location after the first pass. This version randomizes the changed distance, plus it adds a rounding function that handles the positive and negative values of the lat/long coordinates equally well. This results in an improved randomized route for the trucks. Not 100% realistic (data would need to be incorporated for that), but good enough for a simulation.
Improved gps location simulation
Joel Hulen (joelhulen)
requested review from
Devis Lucato (dluc),
Parvez (ppathan) and
Tim Laverty (timlaverty)
as code owners
January 22, 2018 02:14
Member
|
Joel Hulen (@joelhulen) thanks for the PR, we're looking into it |
Member
|
Peter Felts (@peterfelts) could you look at this PR? |
Devis Lucato (dluc)
requested a review
from Harleen Thind (hathind-ms)
as a code owner
October 18, 2018 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change?
Description, Context, Motivation
The previous version never actually changed the truck's location after the first pass. This version randomizes the changed distance, plus it adds a rounding function that handles the positive and negative values of the lat/long coordinates equally well. This results in an improved randomized route for the trucks. Not 100% realistic (data would need to be incorporated for that), but good enough for a simulation.
Checklist:
This change is