Skip to content

SWI-9027 BXML Fixes for Java 25 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckoegel merged 12 commits into from
Aug 7, 2026
Merged

SWI-9027 BXML Fixes for Java 25 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc1cd9e
SWI-9027 BXML Fixes for Java 25
ckoegel Nov 7, 2025
513ee90
add 25 to text matrix
ckoegel Nov 7, 2025
6155baf
run smoke tests
ckoegel Nov 7, 2025
edb0acd
fix transcription test
ckoegel Nov 7, 2025
d148f79
remove newline for smoke test
ckoegel Nov 7, 2025
5bf3421
fix recording verbs
ckoegel Nov 7, 2025
8b5b165
remove newline
ckoegel Nov 7, 2025
b62cabe
add getVerbs
ckoegel Nov 7, 2025
e94fc8a
Merge branch 'main' of https://github.com/Bandwidth/java-sdk into SWI…
ckoegel Aug 6, 2026
2b411b9
revert unnecessary bxml changes
ckoegel Aug 6, 2026
8ea2264
fix transfer test
ckoegel Aug 6, 2026
185f5e8
update pom
ckoegel Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
matrix:
os: [windows-2022, windows-2025, ubuntu-22.04, ubuntu-24.04]
java-version: ["11", "17", "21"]
java-version: ["11", "17", "21", "25"]
distribution: ["zulu", "temurin"]
fail-fast: false
steps:
Expand Down
11 changes: 10 additions & 1 deletion custom_templates/pom.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,14 @@
<arg>-Xlint:all</arg>
<arg>-J-Xss4m</arg><!-- Compiling the generated JSON.java file may require larger stack size. -->
</compilerArgs>
<!-- JDK 23+ no longer auto-discovers annotation processors on the classpath. -->
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -329,7 +337,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.30</version>
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -510,6 +518,7 @@
<version.commons-io>2.14.0</version.commons-io>
<commons-lang3-version>3.18.0</commons-lang3-version>
<jaxb.version>4.0.0</jaxb.version>
<lombok.version>1.18.46</lombok.version>
{{#openApiNullable}}
<jackson-databind-nullable-version>0.2.7</jackson-databind-nullable-version>
{{/openApiNullable}}
Expand Down
11 changes: 10 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@
<arg>-Xlint:all</arg>
<arg>-J-Xss4m</arg><!-- Compiling the generated JSON.java file may require larger stack size. -->
</compilerArgs>
<!-- JDK 23+ no longer auto-discovers annotation processors on the classpath. -->
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -322,7 +330,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.30</version>
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -427,6 +435,7 @@
<version.commons-io>2.14.0</version.commons-io>
<commons-lang3-version>3.18.0</commons-lang3-version>
<jaxb.version>4.0.0</jaxb.version>
<lombok.version>1.18.46</lombok.version>
<jackson-databind-nullable-version>0.2.7</jackson-databind-nullable-version>
<jakarta-annotation-version>1.3.5</jakarta-annotation-version>
<beanvalidation-version>2.0.2</beanvalidation-version>
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/bandwidth/sdk/model/bxml/Bxml.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public class Bxml {
@XmlElement(name = StopStream.TYPE_NAME, type = StopStream.class),
@XmlElement(name = StartTranscription.TYPE_NAME, type = StartTranscription.class),
@XmlElement(name = StopTranscription.TYPE_NAME, type = StopTranscription.class),

})

private List<Verb> verbs = new ArrayList<>();
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/com/bandwidth/sdk/model/bxml/PlayAudio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
import jakarta.xml.bind.annotation.XmlAttribute;
import jakarta.xml.bind.annotation.XmlType;
import jakarta.xml.bind.annotation.XmlValue;
import jakarta.xml.bind.annotation.adapters.XmlJavaTypeAdapter;
import java.net.URI;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.EqualsAndHashCode;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/bandwidth/sdk/model/bxml/StartTranscription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import jakarta.xml.bind.annotation.XmlElements;
import jakarta.xml.bind.annotation.XmlType;
import java.util.List;
import java.util.UUID;

import com.bandwidth.sdk.model.CallDirectionEnum;

Expand Down Expand Up @@ -76,6 +75,7 @@ public class StartTranscription implements Verb {
protected String password;

@XmlAttribute
@Default
protected Boolean stabilized = true;

@XmlElements({
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/bandwidth/sdk/unit/models/bxml/StartTranscriptionVerbTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class StartTranscriptionVerbTest {
@Test
public void startTranscriptionVerbWorks() throws JAXBException {
JAXBContext jaxbContext = JAXBContext.newInstance(Bxml.class);
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartTranscription name=\"test_transcription\" tracks=\"INBOUND\" destination=\"testurl.com\" transcriptionEventUrl=\"eventurl.com\" transcriptionEventMethod=\"POST\" username=\"user\" password=\"pass\"><CustomParam name=\"name1\" value=\"value1\"/><CustomParam name=\"name2\" value=\"value2\"/></StartTranscription></Bxml>";
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartTranscription name=\"test_transcription\" tracks=\"INBOUND\" destination=\"testurl.com\" transcriptionEventUrl=\"eventurl.com\" transcriptionEventMethod=\"POST\" username=\"user\" password=\"pass\" stabilized=\"true\"><CustomParam name=\"name1\" value=\"value1\"/><CustomParam name=\"name2\" value=\"value2\"/></StartTranscription></Bxml>";

assertThat(new Bxml().with(startTranscription).toBxml(jaxbContext), is(expectedBxml));
}
Expand Down