VAPI-3661 fix(deps): downgrade uuid to ^11 to restore CommonJS compatibility - #14
Open
smoghe-bw wants to merge 1 commit into
Open
VAPI-3661 fix(deps): downgrade uuid to ^11 to restore CommonJS compatibility#14smoghe-bw wants to merge 1 commit into
smoghe-bw wants to merge 1 commit into
Conversation
uuid@^13 is ESM-only; the CommonJS dist compiles import statements to require() calls, causing ERR_REQUIRE_ESM at runtime in Node.js consumers. uuid@11.x is the last release line that ships a CJS entry point. Also bumps rpc-websockets 7.10.0 → ^10.0.1 (setAutoReconnect API unchanged, verified via types) and webrtc-adapter ^9.0.3 → ^9.0.6. Drops @types/uuid since uuid@11 bundles its own declarations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
smoghe-bw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uuid@^13is ESM-only, but the SDK's TypeScript config targets CommonJS — the compileddist/v1/signaling.jsemitsrequire('uuid'), which Node.js rejects withERR_REQUIRE_ESMat runtime.uuid^13.0.0→^11.0.4— last release line that ships a CJS entry point. uuid@11 also bundles its own type declarations, so@types/uuidis dropped.rpc-websockets7.10.0→^10.0.1— verified thatsetAutoReconnect,call,notify, and constructor options (autoconnect,reconnect,max_reconnects) are all API-stable across the major version.webrtc-adapter^9.0.3→^9.0.6(patch).Test plan
npm run buildcompiles cleanly with no TypeScript errorsnpm test— 71/71 tests pass (verified locally)ERR_REQUIRE_ESM🤖 Generated with Claude Code