FILT: Port EMsoftSO3Sampler Filter#16
Open
imikejackson wants to merge 1 commit into
Open
Conversation
imikejackson
force-pushed
the
filter/so3_sampler
branch
from
December 19, 2025 17:21
2e8079f to
a928241
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| m_EulerAnglesStoreRef.setValue(j * 3 + 2, static_cast<float>(eu[2])); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| DataGroupCreationParameter::ValueType({"Ensemble Attribute Matrix"}))); | ||
| params.insert(std::make_unique<ArrayCreationParameter>(k_EulerAnglesArrayPath_Key, "Euler Angles", "Output array to hold the generated Euler Angles", DataPath({"Euler Angles"}))); | ||
|
|
||
|
|
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| { | ||
| return MakePreflightErrorResult(-70002, "Misorientation angle must fall in interval [0,90]"); | ||
| } | ||
| ebsdlib::EulerFType euler(pRefOrValue[0] * nx::core::Constants::k_PiOver180F, pRefOrValue[1] * nx::core::Constants::k_PiOver180F, pRefOrValue[2] * nx::core::Constants::k_PiOver180F); |
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| ebsdlib::EulerFType euler(pRefOrValue[0] * nx::core::Constants::k_PiOver180F, pRefOrValue[1] * nx::core::Constants::k_PiOver180F, pRefOrValue[2] * nx::core::Constants::k_PiOver180F); | |
| ebsdlib::EulerFType euler(pRefOrValue[0] * nx::core::Constants::k_PiOver180F, pRefOrValue[1] * nx::core::Constants::k_PiOver180F, pRefOrValue[2] * nx::core::Constants::k_PiOver180F); |
imikejackson
force-pushed
the
filter/so3_sampler
branch
3 times, most recently
from
February 25, 2026 03:44
60dff30 to
17eb9a5
Compare
imikejackson
force-pushed
the
filter/so3_sampler
branch
from
March 4, 2026 18:52
17eb9a5 to
e29cbc5
Compare
imikejackson
force-pushed
the
filter/so3_sampler
branch
from
April 27, 2026 15:57
e29cbc5 to
14bc551
Compare
imikejackson
force-pushed
the
filter/so3_sampler
branch
from
May 12, 2026 19:27
14bc551 to
90f4b07
Compare
imikejackson
force-pushed
the
filter/so3_sampler
branch
from
June 29, 2026 13:38
90f4b07 to
a812801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.