ENH: Refresh stale filter arguments in example pipelines#1677
Open
imikejackson wants to merge 1 commit into
Open
ENH: Refresh stale filter arguments in example pipelines#1677imikejackson wants to merge 1 commit into
imikejackson wants to merge 1 commit into
Conversation
* Round-trips 44 example pipelines through Pipeline::FromFile/toJson so every filter carries its current full parameter key set and version, eliminating the -5432/-5433 load warnings DREAM3D-NX shows * Value-preserving key renames: surface_mesh_face_ipf_colors_array_name -> first_face_ipf_colors_array_name, surface_mesh_face_misorientation_ colors_array_name -> misorientation_array_name, z_value_choice -> z_value_choice_index * GUI-level top-level fields (pipeline_uuid, workflowParams, pinnedParams) and all filter comments preserved * V&V comparison pipelines left untouched (provenance artifacts) Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes 44 example
.d3dpipelinefiles whose filter arguments had gone stale as filters gained or renamed parameters, eliminating the-5432/-5433"Parameter key not found" warnings DREAM3D-NX shows when loading them.Pipeline::FromFile→toJson(via the python bindings) so every filter now serializes its current full parameter key set, defaults, andparameters_version— identical to what DREAM3D-NX would save today.surface_mesh_face_ipf_colors_array_name→first_face_ipf_colors_array_name(following the filter's own SIMPL-converter precedent; the second color array keeps its default name)surface_mesh_face_misorientation_colors_array_name→misorientation_array_namez_value_choice→z_value_choice_indexpipeline_uuid,workflowParams,pinnedParams) and all filter comments are preserved; corePipeline::toJsondoes not emit the GUI fields, so they were re-applied from the original files.vv/are deliberately untouched (provenance artifacts).Test Plan
vv/pipeline still warns).Import_CSV_File.d3dpipelineexecutes end-to-end cleanly via nxrunner.Note:
ExtractFeatureBoundaries2D.d3dpipelinecontains a pre-existing hard-coded absolute input path from another machine and cannot execute portably; left for a separate fix.