test: add Pest v1 security test infrastructure - #20
Draft
somethingwithproof wants to merge 7 commits into
Draft
Conversation
Add source-scan tests verifying security patterns (prepared statements, output escaping, auth guards, PHP 7.4 compatibility) remain in place across refactors. Tests run with Pest v1 (PHP 7.3+) and stub the Cacti framework so plugins can be tested in isolation. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a Pest v1-based test scaffold for the plugin_apcupsd repository, focusing on lightweight security/regression checks (setup.php structure, prepared-statement usage consistency, and PHP 7.4 syntax compatibility) plus basic test bootstrapping.
Changes:
- Introduces Pest configuration and a bootstrap with stubbed Cacti framework functions/constants for isolated test execution.
- Adds security-oriented source-scan tests (setup.php structure, prepared-statement consistency, PHP 7.4 compatibility checks).
- Adds
composer.jsondev dependency for Pest and a Dependabot configuration.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Security/SetupStructureTest.php |
Source-scan assertions for required plugin hook functions/metadata in setup.php. |
tests/Security/PreparedStatementConsistencyTest.php |
Scans key plugin files for raw db_* calls to enforce prepared helper usage. |
tests/Security/Php74CompatibilityTest.php |
Scans for a small set of PHP 8-only APIs/operators to keep PHP 7.4 compatibility. |
tests/Pest.php |
Loads test bootstrap for Pest runs. |
tests/bootstrap.php |
Provides stubs for common Cacti functions/constants to support isolated loading. |
composer.json |
Adds Pest v1 as a dev dependency and wires in test bootstrap autoloading. |
.github/dependabot.yml |
Adds Dependabot config (currently for npm + GitHub Actions). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…dabot - Throw RuntimeException when realpath/file_get_contents fails (previously silent continue hid unscanned files) - Fix Dependabot ecosystem from npm to composer - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
marked this pull request as draft
April 11, 2026 00:09
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #16; will un-draft after that merges to avoid cross-PR merge conflicts. |
pest ^1.23 never shipped describe(), so the whole suite errored out; also narrows the prepared-statement check to migrated files and reads name/version from INFO instead of grepping setup.php source. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
composer install && vendor/bin/pestpasses