update: Sail to 0.6.6#982
Open
shehabgamin wants to merge 3 commits into
Open
Conversation
shehabgamin
commented
Jul 12, 2026
| SELECT SearchPhrase FROM hits WHERE SearchPhrase <> '' ORDER BY EventTime, SearchPhrase LIMIT 10; | ||
| SELECT CounterID, AVG(length(URL)) AS l, COUNT(*) AS c FROM hits WHERE URL <> '' GROUP BY CounterID HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; | ||
| SELECT REGEXP_REPLACE(Referer, '^https?://(?:www\.)?([^/]+)/.*$', '\1') AS k, AVG(length(Referer)) AS l, COUNT(*) AS c, MIN(Referer) FROM hits WHERE Referer <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; | ||
| SELECT REGEXP_REPLACE(Referer, '^https?://(?:www\.)?([^/]+)/.*$', '$1') AS k, AVG(length(Referer)) AS l, COUNT(*) AS c, MIN(Referer) FROM hits WHERE Referer <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; |
Contributor
Author
There was a problem hiding this comment.
Query was previously returning incorrect results. Should be $1.
shehabgamin
commented
Jul 12, 2026
|
|
||
| os.environ["SAIL_PARQUET__BINARY_AS_STRING"] = "true" | ||
| os.environ["SAIL_PARQUET__REORDER_FILTERS"] = "true" | ||
| os.environ["SAIL_OPTIMIZER__ENABLE_JOIN_REORDER"] = "true" |
Contributor
Author
There was a problem hiding this comment.
This does nothing since ClickBench has no joins
shehabgamin
commented
Jul 12, 2026
|
|
||
| os.environ["SAIL_PARQUET__BINARY_AS_STRING"] = "true" | ||
| os.environ["SAIL_PARQUET__REORDER_FILTERS"] = "true" | ||
| os.environ["SAIL_OPTIMIZER__ENABLE_JOIN_REORDER"] = "true" |
Contributor
Author
There was a problem hiding this comment.
This does nothing since ClickBench has no joins
shehabgamin
commented
Jul 12, 2026
| SELECT SearchPhrase FROM hits WHERE SearchPhrase <> '' ORDER BY EventTime, SearchPhrase LIMIT 10; | ||
| SELECT CounterID, AVG(length(URL)) AS l, COUNT(*) AS c FROM hits WHERE URL <> '' GROUP BY CounterID HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; | ||
| SELECT REGEXP_REPLACE(Referer, '^https?://(?:www\.)?([^/]+)/.*$', '\1') AS k, AVG(length(Referer)) AS l, COUNT(*) AS c, MIN(Referer) FROM hits WHERE Referer <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; | ||
| SELECT REGEXP_REPLACE(Referer, '^https?://(?:www\.)?([^/]+)/.*$', '$1') AS k, AVG(length(Referer)) AS l, COUNT(*) AS c, MIN(Referer) FROM hits WHERE Referer <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25; |
Contributor
Author
There was a problem hiding this comment.
Query was previously returning incorrect results. Should be $1.
shehabgamin
commented
Jul 12, 2026
| spark = SparkSession.builder.remote(f"sc://localhost:{port}").getOrCreate() | ||
|
|
||
| df = spark.read.parquet("partitioned") | ||
| df = df.withColumn("EventTime", F.col("EventTime").cast("timestamp")) |
Contributor
Author
There was a problem hiding this comment.
I added this in #967, turns out it is unnecessary.
shehabgamin
commented
Jul 12, 2026
| spark = SparkSession.builder.remote(f"sc://localhost:{port}").getOrCreate() | ||
|
|
||
| df = spark.read.parquet("hits.parquet") | ||
| df = df.withColumn("EventTime", F.col("EventTime").cast("timestamp")) |
Contributor
Author
There was a problem hiding this comment.
I added this in #967, turns out it is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.