CI | Bump Node.js to 22 - #47
Merged
Merged
Conversation
jsdom 30 and undici require Node >=22.19; Node 20 CI failed the DOM suite with an unhandled Vitest worker error. Co-authored-by: Cursor <cursoragent@cursor.com>
OctavusClient requires baseUrl/apiKey at construction; CI only had AGENT_ID, so the server crashed before the stubbed audit could run. Co-authored-by: Cursor <cursoragent@cursor.com>
checkout@v6, setup-node@v6, and upload-artifact@v7 clear the Node 20 deprecation warning on GitHub-hosted runners. Co-authored-by: Cursor <cursoragent@cursor.com>
BrianGenisio
marked this pull request as ready for review
August 7, 2026 20:52
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe CI and release workflows now use checkout and Node setup actions at version 6. They configure Node.js 22 instead of Node.js 20. Artifact uploads now use version 7. The pull request workflow passes separate placeholder values for the Octavus API URL, API key, and agent ID to the CI server. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was failing the PR workflow even when unit assertions looked green. Vitest could not start the jsdom worker for
tests/dom/render.test.json Node 20, so the run exited with one unhandled error.Changes
Bumps
actions/setup-nodefrom Node 20 to Node 22 inpr.ymlandrelease.yml.jsdom@30/undici@8need Node>=22.19. Local runs on Node 26 passed; CI on 20 crashed before the DOM suite started. 22 is the oldest LTS that matches those engines.Test plan
npm testcompletes with the DOM suite (no unhandled Vitest worker error)