London | 26-ITP-May | Chun Yan Wong | Sprint 3 | implement and rewrite-test#1490
Open
cywong-dev wants to merge 9 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 3 | implement and rewrite-test#1490cywong-dev wants to merge 9 commits into
cywong-dev wants to merge 9 commits into
Conversation
Implemented the getAngleType function to classify angles.
Implement isProperFraction function to check if a fraction is proper.
Implement getCardValue function to return card values based on rank.
Added implementation comment for the getCardValue function.
Added Jest test cases for proper fraction validation.
Throw an error for invalid card strings.
cywong-dev
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
[X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
[X] My changes meet the requirements of the task
[X] I have tested my changes
[X] My changes follow the style guide
Changelist
The test cases have been rewritten in Jest