Skip to content

GMT-1740: promote deep-import types to public API - #3412

Draft
dreamwasp wants to merge 10 commits into
mainfrom
cass-gmt-1740
Draft

GMT-1740: promote deep-import types to public API#3412
dreamwasp wants to merge 10 commits into
mainfrom
cass-gmt-1740

Conversation

@dreamwasp

Copy link
Copy Markdown
Contributor

No description provided.

…o public API

Part of the GMT-1740 exports-map migration. Promotes types from
packages/gamut/src/PopoverContainer/types.ts and
Form/SelectDropdown/types/* to the package root so consumers can stop
reaching into internal dist/ paths.
@nx-cloud

nx-cloud Bot commented Aug 17, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 4aaeae5

Command Status Duration Result
nx run-many --target=verify --parallel=3 --all ✅ Succeeded 2s View ↗
nx run-many --target=build --all ✅ Succeeded 43s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-25 18:01:57 UTC

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1252 1 1251 0
View the top 1 failed test(s) by shortest run time
 Gamut Exported Keys
Stack Traces | 0.005s run time
Error: expect(received).toMatchSnapshot()

Snapshot name: `Gamut Exported Keys 1`

- Snapshot  -  0
+ Received  + 33

@@ -3,13 +3,16 @@
    "Anchor",
    "AnchorBase",
    "AppWrapper",
    "Badge",
    "BarChart",
+   "BaseOnChangeProps",
    "BodyPortal",
    "Box",
    "Breadcrumbs",
+   "ButtonBase",
+   "buttonProps",
    "Card",
    "Checkbox",
    "Coachmark",
    "Column",
    "ConnectedCheckbox",
@@ -21,12 +24,18 @@
    "ConnectedRadioGroup",
    "ConnectedRadioGroupInput",
    "ConnectedSelect",
    "ConnectedTextArea",
    "ContentContainer",
+   "ControlState",
+   "createCodeBlockOverride",
+   "createInputOverride",
    "createPromise",
+   "createTagOverride",
+   "createVideoOverride",
    "CTAButton",
+   "CustomSelectComponentProps",
    "DataList",
    "DataTable",
    "DatePicker",
    "DatePickerCalendar",
    "DatePickerInput",
@@ -35,10 +44,11 @@
    "Dialog",
    "Disclosure",
    "Drawer",
    "ExpandControl",
    "ExpandInCollapseOut",
+   "ExtendedOption",
    "FadeInSlideOut",
    "FeatureShimmer",
    "FillButton",
    "FlexBox",
    "Flyout",
@@ -55,25 +65,36 @@
    "getFocusableElements",
    "GridBox",
    "GridForm",
    "GridFormContent",
    "IconButton",
+   "IconOption",
+   "IconOptionComponent",
    "iFrameWrapper",
    "InfoTip",
    "Input",
+   "InteractiveSelectors",
    "isClickableCrumb",
    "LayoutGrid",
    "List",
    "ListCol",
    "ListRow",
    "Markdown",
    "matchDisabledDates",
    "Menu",
    "MenuItem",
+   "MenuList",
+   "MenuListButton",
+   "MenuListItem",
+   "MenuListLink",
    "MenuSeparator",
+   "MenuToolTipWrapper",
    "Modal",
+   "MultiSelectDropdownProps",
    "omitProps",
+   "OptionState",
+   "OptionStrict",
    "Overlay",
    "Pagination",
    "Popover",
    "PopoverContainer",
    "PreviewTip",
@@ -84,14 +105,22 @@
    "reactRecurlyFormFieldFocusStyles",
    "reactRecurlyFormFieldPaddingStyles",
    "Rotation",
    "Select",
    "SelectDropdown",
+   "SelectDropdownContextValueTypes",
+   "SelectDropdownGroup",
+   "SelectDropdownOptions",
+   "SelectDropdownProps",
+   "SelectDropdownSizes",
    "Shimmer",
+   "SingleSelectDropdownProps",
+   "SizedIndicatorProps",
    "SkipToContent",
    "SkipToContentTarget",
    "Spinner",
+   "standardOverrides",
    "StrokeButton",
    "SubmitButton",
    "submitSuccessStatus",
    "Tab",
    "TableHeader",
@@ -103,14 +132,18 @@
    "Tabs",
    "Tag",
    "Text",
    "TextArea",
    "TextButton",
+   "tipAlignmentArray",
+   "tipBaseAlignmentArray",
+   "tipDefaultProps",
    "Toast",
    "Toaster",
    "Toggle",
    "ToolTip",
+   "TypedReactSelectProps",
    "USE_DEBOUNCED_FIELD_DIRTY_KEY",
    "useConnectedForm",
    "useDatePicker",
    "useDebouncedField",
    "useField",
    at Object.<anonymous> (.../gamut/__tests__/gamut.test.ts:7:25)
    at Promise.finally.completed (.../jest-circus/build/jestAdapterInit.js:1561:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/jestAdapterInit.js:1501:10)
    at _callCircusTest (.../jest-circus/build/jestAdapterInit.js:1011:40)
    at async _runTest (.../jest-circus/build/jestAdapterInit.js:951:3)
    at async .../jest-circus/build/jestAdapterInit.js:853:7
    at async _runTestsForDescribeBlock (.../jest-circus/build/jestAdapterInit.js:866:11)
    at async run (.../jest-circus/build/jestAdapterInit.js:765:3)
    at async runAndTransformResultsToJestFormat (.../jest-circus/build/jestAdapterInit.js:1993:21)
    at async jestAdapter (.../jest-circus/build/runner.js:111:19)
    at async runTestInternal (.../jest-runner/build/index.js:276:16)
    at async runTest (.../jest-runner/build/index.js:344:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Dropped during the export-* switch, breaking GridForm/types.ts's import.
…ublic API

Renamed to match real usage (Anchor, Tag, Tip, Pagination — not just
Button/ButtonBase), then exported from the root barrel. Documented
alongside the other style utility helpers in Storybook.
# Conflicts:
#	packages/gamut/src/Anchor/index.tsx
#	packages/gamut/src/ButtonBase/ButtonBase.tsx
#	packages/gamut/src/Menu/MenuItem.tsx
#	packages/gamut/src/PopoverContainer/PopoverContainer.tsx
#	packages/gamut/src/PopoverContainer/types.ts
@github-actions

Copy link
Copy Markdown
Contributor

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 73.3.1-alpha.0e5de6.0 npm diff
@codecademy/gamut-icons 10.1.1-alpha.0e5de6.0 npm diff
@codecademy/gamut-illustrations 1.1.1-alpha.0e5de6.0 npm diff
@codecademy/gamut-kit 3.0.21-alpha.0e5de6.0 npm diff
@codecademy/gamut-patterns 1.1.1-alpha.0e5de6.0 npm diff
@codecademy/gamut-styles 21.2.1-alpha.0e5de6.0 npm diff
@codecademy/gamut-tests 7.1.1-alpha.0e5de6.0 npm diff
@codecademy/variance 1.1.1-alpha.0e5de6.0 npm diff
eslint-plugin-gamut 3.1.1-alpha.0e5de6.0 npm diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants