Restore doctrine.connections after kernel shutdown#244
Merged
TavoNiievez merged 2 commits intoJul 10, 2026
Merged
Conversation
Member
|
Hi @d-mitrofanov-v Please create a test similar to: |
Contributor
Author
|
@TavoNiievez hi. Done - Codeception/symfony-module-tests#67 |
618224d to
f797a36
Compare
Member
|
@d-mitrofanov-v Released as 3.10.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys! After updating to 3.10 in my projects, all tests started failing with error:
The combined changes in persistDoctrineConnections in 3.9.0 and in _getEntityManager in 3.10.0 opened this bug, because
Symfony::rebootKernel()removesdoctrine.connectionsto prevent DoctrineBundle from closing the persistent DBAL connection during kernel shutdown and this parameter is never restored, leaving the previous container broken.Tried to make a minimal change. We remove the parameter in the kernel shutdown phase and restores it afterward. The restoration is also done when kernel shutdown throws. The DBAL connection stays persistent, while the entity manager is still recreated from the current container.