Add autocomplete suggestions for previously checked list items - #1087
Open
Ruj89 wants to merge 1 commit into
Open
Add autocomplete suggestions for previously checked list items#1087Ruj89 wants to merge 1 commit into
Ruj89 wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesChecked-item autocomplete
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Editor
participant ListItemVH
participant ListManager
participant ListState
Editor->>ListItemVH: type item text
ListItemVH->>ListManager: request checked-item suggestions
ListManager-->>ListItemVH: return up to two matches
ListItemVH-->>Editor: display suggestion popup
Editor->>ListItemVH: select suggestion
ListItemVH->>ListManager: complete selected checked item
ListManager->>ListState: replace current item and remove selected subtree
ListState-->>ListManager: return updated state and focus position
ListManager-->>ListItemVH: apply batch change and update counts
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces autocomplete for checked checklist items, making recurring lists faster and easier to reuse.
When the user starts typing a new item, NotallyX now searches previously checked entries and displays up to two matching suggestions. Matching is case-insensitive, starts after two characters, and only considers items whose text begins with the entered query.
Selecting a suggestion:
The implementation supports both standard lists and lists using automatic sorting by checked status. The suggestion popup is also dismissed appropriately when the item loses focus or its ViewHolder is rebound.
Summary by CodeRabbit