Skip to content

fix: add shebang to run_detached script - #8716

Merged
aldbr merged 2 commits into
DIRACGrid:integrationfrom
natthan-pigoux:fix_host_submit_job
Aug 3, 2026
Merged

fix: add shebang to run_detached script#8716
aldbr merged 2 commits into
DIRACGrid:integrationfrom
natthan-pigoux:fix_host_submit_job

Conversation

@natthan-pigoux

Copy link
Copy Markdown
Contributor

Add shebang to run_detached.sh script to run subprocess without shell=True which results as a bandit security issue.

closes #8715

Comment thread src/DIRAC/Resources/Computing/BatchSystems/Host.py Outdated
@natthan-pigoux natthan-pigoux self-assigned this Jul 29, 2026
@fstagni

fstagni commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Please check for other places where same fix might be needed, especially in the Batch System folder.

@natthan-pigoux

natthan-pigoux commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Please check for other places where same fix might be needed, especially in the Batch System folder.

I've been through #8587 and #8605 . This was the only shell=True that was actually removed.

I also had a look for subprocess commands in the BatchSystem folder, and I didn't notice any other case. Simon properly left shell=True when needed.

@aldbr
aldbr force-pushed the fix_host_submit_job branch from 29f560f to d6199dd Compare August 3, 2026 08:31
@aldbr
aldbr merged commit 9b508b7 into DIRACGrid:integration Aug 3, 2026
23 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sweep:ignore Prevent sweeping from being ran for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: run_detached.sh script is ran as a binary by SSHComputingElement

5 participants