ci(release): hint at crates left out of a proposal affected by its major bumps - #2391
Draft
iunanua wants to merge 1 commit into
Draft
ci(release): hint at crates left out of a proposal affected by its major bumps#2391iunanua wants to merge 1 commit into
iunanua wants to merge 1 commit into
Conversation
…jor bumps Release candidates only come from publication-order.sh, which walks downward: the selected crates plus the libdd-* crates they depend on. Dependents outside that closure are never candidates, yet `cargo release version` still rewrites their dependency requirement to the new major. Their published version keeps requiring the old major, and their next proposal is force-bumped to major by major-bumps-level.sh with nothing having said so at the time. Report those crates, grouped by the major-bumped dependency, in the job log, the step summary and the proposal PR body. A crate is reported when it has a direct (non-dev, non-build) dependency on a crate released here at level major whose requirement now names the new major, which is the same extraction rule major-bumps-level.sh applies, so a hint cannot disagree with the audit that runs next time. The step is informational: it never touches the tree, always exits 0, and carries continue-on-error so a bug in the hints cannot fail a run whose version bumps are already committed. When nothing is affected the markdown file is empty and the PR body is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 51600cc | Docs | View more details | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Release candidates only come from publication-order.sh, which walks downward: the selected crates plus the libdd-* crates they depend on. Dependents outside that closure are never candidates, yet
cargo release versionstill rewrites their dependency requirement to the new major. Their published version keeps requiring the old major, and their next proposal is force-bumped to major by major-bumps-level.sh with nothing having said so at the time.Report those crates, grouped by the major-bumped dependency, in the job log, the step summary and the proposal PR body. A crate is reported when it has a direct (non-dev, non-build) dependency on a crate released here at level major whose requirement now names the new major, which is the same extraction rule major-bumps-level.sh applies, so a hint cannot disagree with the audit that runs next time.
The step is informational.