chore: migrate to noqueue merge queue strategy - #2424
Open
brettlangdon wants to merge 1 commit into
Open
Conversation
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 0e3a0d8 | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These are similar settings adopted by dd-trace-py.
noqueue is recommended for repos who have "slow" CI such that multiple PRs in the MQ don't stack and delay each other.
While a PR being added to the MQ will get rebased on base branch first, we lose the guarantee of no conflicts between multiple PRs in the MQ.
The net result should be faster MQ merges since PRs won't stack.
The other valuable settings are for ensuring the MQ workflow fails as soon as any GitLab jobs fail, so a failing MQ run won't wait for the pipeline to complete first before bailing.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.