Add is_enemy tag#2837
Open
creaturesofhabit wants to merge 2 commits into
Open
Conversation
MC-Samuel
reviewed
Jul 22, 2026
MC-Samuel
left a comment
MC-Samuel
left a comment
Contributor
There was a problem hiding this comment.
Very good for your first PR!
| return getBukkitEntity() instanceof Monster; | ||
| } | ||
|
|
||
| public boolean isEnemyType() { |
Contributor
There was a problem hiding this comment.
Does this need to be a separate method and not part of the tag?
Author
There was a problem hiding this comment.
Added to entity matcher to match similar tags
| if (getBukkitEntity() == null && entity_type != null) { | ||
| return Enemy.class.isAssignableFrom(entity_type.getBukkitEntityType().getEntityClass()); | ||
| } | ||
| return getBukkitEntity() instanceof Enemy; |
Contributor
There was a problem hiding this comment.
This line should be all that's required.
Contributor
There was a problem hiding this comment.
the entity_type check allows unspawned entities (eg, <entity[zombie].is_enemy>) to check correctly when getBukkitEntity() is null
| // @returns ElementTag(Boolean) | ||
| // @group data | ||
| // @description | ||
| // Returns whether the entity type is an enemy. See <@link url https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Enemy.html> |
Contributor
There was a problem hiding this comment.
Not sure the link is necessary, unless you're referencing entities that Spigot defines as "enemies"?
This also requires/justifies the seperate method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this thread, adds the 1.19+ is_enemy tag to return if the entity is in spigot's enemy interface