add item_name property#2838
Open
creaturesofhabit wants to merge 1 commit into
Open
Conversation
tal5
requested changes
Jul 24, 2026
tal5
left a comment
tal5
left a comment
Member
There was a problem hiding this comment.
I also feel like the meta could explain how this works in relation to ItemTag.display better? But I don't really have any rewrite suggestions so it could be fine as-is for now
|
|
||
| @Override | ||
| public ElementTag toDenizen(Component value) { | ||
| return new ElementTag(LegacyComponentSerializer.legacyAmpersand().serialize(value)); |
Member
There was a problem hiding this comment.
These would lose all advanced text formatting, you want the methods from PaperModule here (and in the other method)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://discord.com/channels/315163488085475337/1362329776475603057. Works as expected on 26.2 and 26.1.
Considered mentioning this property in the item.display documentation since this is probably to be preferred for most use-cases, but didn't want to mess with other files.